Skip to content

feat(cli): narrow fast_provision experiment to images-only#3371

Merged
la14-1 merged 1 commit intoOpenRouterTeam:mainfrom
AhmedTMM:experiment-images-only
Apr 29, 2026
Merged

feat(cli): narrow fast_provision experiment to images-only#3371
la14-1 merged 1 commit intoOpenRouterTeam:mainfrom
AhmedTMM:experiment-images-only

Conversation

@AhmedTMM
Copy link
Copy Markdown
Collaborator

Summary

  • Drop tarball from the fast_provision PostHog experiment's test variant — bucketed users now only get images flipped on, not tarball + images.
  • Cleaner attribution: the A/B hypothesis isolates the marketplace-image boot-time speedup. Tarball install stays available via explicit --beta tarball or --fast.
  • Bumps CLI to 1.0.24.

Test plan

  • bunx @biomejs/biome check src/ — clean
  • bun test src/__tests__/feature-flags.test.ts — 11/11 pass
  • Full bun test — only 4 pre-existing cross-file fetch-mock pollution failures (cmdrun-happy-path, hetzner-cov, digitalocean-token), all pass in isolation. Unrelated to this diff.

🤖 Generated with Claude Code

@la14-1
Copy link
Copy Markdown
Member

la14-1 commented Apr 29, 2026

Review

Small, mechanical narrowing of the `fast_provision` `test` variant from `tarball + images` → `images`. Code change is fine; the real questions are upstream of the code.

Looks good

  • One-line diff, comment updated to match. No test changes needed (the flag-evaluation tests don't assert on which betas get pushed).
  • Still respects `userOptedIntoBeta` — users who explicitly pass `--beta` or `--fast` get the full set.

Must-fix before merge

Worth confirming before flipping

Nit

  • Consider adding a single unit test that asserts `betaFeatures` contains exactly `["images"]` when the flag returns `test` and the user didn't opt in — cheap guard against a future "oops pushed tarball back in" regression. Not blocking.

Draft state

PR is marked draft; treat this as pre-review feedback. Ready it once the rebase + version bump is in and you've decided on the PostHog experiment reset question.

Reviewed by SPA

Drop `tarball` from the experiment's `test` variant so the A/B
hypothesis isolates the marketplace-image speedup. Tarball install
remains available via `--beta tarball` and `--fast` for power users —
just no longer auto-applied to bucketed users.

Bumps version to 1.0.24.
@la14-1 la14-1 force-pushed the experiment-images-only branch from cd9ad03 to 233b0ad Compare April 29, 2026 16:40
@la14-1 la14-1 marked this pull request as ready for review April 29, 2026 16:40
Copy link
Copy Markdown
Member

@la14-1 la14-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased onto main + bumped to 1.0.26. Per-request, skipping the unit-test nit.

@la14-1 la14-1 merged commit 5599070 into OpenRouterTeam:main Apr 29, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants