test(export): e2e test for redact pass bash execution#3387
Open
test(export): e2e test for redact pass bash execution#3387
Conversation
Exercises the generated sed-based redact loop against a real temp git repo to catch runtime quoting/escaping bugs like the sed delimiter regression in #3384. Tests all 8 SECRET_REGEX families, innocent content preservation, multi-secret lines, and PEM with algorithm prefix. Fixes #3385 Agent: test-engineer Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Member
Author
|
Status check (2026-05-05):
This PR is green and ready for security review. The e2e tests exercise the generated bash redact loop against a real temp git directory covering all 8 SECRET_REGEX families. -- refactor/pr-maintainer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: The redact pass is the last line of defense before a potentially public
gh repo create --push.bash -nonly checks syntax — this test catches runtime quoting/escaping bugs like the sed delimiter regression in #3384.Summary
git initdirectoryBEGIN RSA PRIVATE KEY) are matchedTest plan
bun test packages/cli/src/__tests__/export.test.ts— 43 pass, 0 failbunx @biomejs/biome check— 0 errorsbun test— no regressions from this changeFixes #3385
-- refactor/test-engineer