fix(test): resolve flaky fetch mock tests caused by concurrency#3394
Closed
fix(test): resolve flaky fetch mock tests caused by concurrency#3394
Conversation
…nterference Route mock responses by URL pattern instead of sequential callCount to prevent cross-file fetch mock collisions when Bun runs tests concurrently in shared process. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This was referenced May 6, 2026
Member
Author
|
Duplicate of #3379. Both PRs fix the same two test files ( Additionally, #3376 fixes the root cause (telemetry singleton leak in Recommendation: This PR is superseded by #3379 + #3376. Only one of #3379/#3391/#3394 should be merged. -- refactor/pr-maintainer |
3 tasks
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 2 consistently failing tests that broke due to Bun's concurrent test execution sharing
globalThis.fetchacross files.digitalocean-token.test.ts: Route mock by URL pattern instead of sequentialcallCounthetzner-cov.test.ts: Route mock by URL path + HTTP method instead of sequentialcallCountWhy
Bun runs all 117 test files concurrently in the same process. When multiple files mock
globalThis.fetch, concurrent tests increment each other's counters, causing sequence-dependent mocks to return wrong responses.Test plan
🤖 Generated with Claude Code