Merged
Conversation
Collaborator
ylvaselling
requested changes
Feb 5, 2026
Co-authored-by: Ylva Selling <ylva.selling@gmail.com>
Co-authored-by: Ylva Selling <ylva.selling@gmail.com>
Co-authored-by: Ylva Selling <ylva.selling@gmail.com>
Co-authored-by: Ylva Selling <ylva.selling@gmail.com>
Contributor
Author
|
I updated with all of your suggestions, however I couldn't get the address property to work without having to change it in the openspace.cfg (I was able to get the allow to work by changing at runtime) I think the problem comes from here: https://github.com/OpenSpace/OpenSpace-WebGuiBackend/blob/fb89a8ca4a4e645f558a692a4c59548650d7df2b/backend.js#L97 where we are sending that value to the gui but not pulling it from the engine on demand. |
Contributor
Author
engbergandreas
approved these changes
Feb 11, 2026
ylvaselling
approved these changes
Feb 24, 2026
Co-authored-by: Alexander Bock <mail@alexanderbock.eu> Co-authored-by: Ylva Selling <ylva.selling@gmail.com>
Co-authored-by: Alexander Bock <mail@alexanderbock.eu>
alexanderbock
approved these changes
Feb 26, 2026
WeirdRubberDuck
added a commit
to OpenSpace/OpenSpace
that referenced
this pull request
Mar 18, 2026
* Windown panel reordering OpenSpace/OpenSpace-WebGui#202 * Fixes #3914 * QR code emnu modal to open GUI in browser: OpenSpace/OpenSpace-WebGui#198
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Added a menu modal for showing a QR code to open the routes page on a device. Open to any/all changes.
Note: in order to use this in dev mode, you must change your enviornment.js and set your computers IP address instead of localhost.
Note: once we fix this issue on openspace: OpenSpace/OpenSpace#1804 we can get rid of the first Alert box, but I think we will always need the 2nd alert box because of security.