Skip to content

Fix App renderer configuration default visibility#900

Merged
Kyle-Ye merged 1 commit into
mainfrom
codex/fix-uitest-app-renderer-configuration
Jun 7, 2026
Merged

Fix App renderer configuration default visibility#900
Kyle-Ye merged 1 commit into
mainfrom
codex/fix-uitest-app-renderer-configuration

Conversation

@Kyle-Ye
Copy link
Copy Markdown
Member

@Kyle-Ye Kyle-Ye commented Jun 7, 2026

Agent Summary

Make the default App.rendererConfiguration implementation visible to regular OpenSwiftUI imports so TestingHostApp can satisfy App without adding a local override.

The stdout renderer configuration requirement remains SPI-gated, while the default nil witness is available for conforming app types. This fixes the UI test host build regression after #893 when OSUI_UITests imports TestingHost.

Validation

  • ./setup.sh from Example
  • xcodebuild -workspace Example/Example.xcworkspace -scheme OSUI_UITests -destination 'generic/platform=iOS Simulator' -configuration OpenSwiftUIDebug build CODE_SIGNING_ALLOWED=NO

@github-actions github-actions Bot added area: app-scene App, scene, window, commands, storage, and lifecycle APIs. type: bug Something is not working correctly. labels Jun 7, 2026
@Kyle-Ye Kyle-Ye marked this pull request as ready for review June 7, 2026 19:12
@Kyle-Ye
Copy link
Copy Markdown
Member Author

Kyle-Ye commented Jun 7, 2026

/uitest macos

@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented Jun 7, 2026

🤖 Augment PR Summary

Summary: Makes the default App.rendererConfiguration witness publicly visible (non-SPI) so regular OpenSwiftUI imports can satisfy App without a local override.
Why: Fixes the UI test host build regression introduced after #893 while keeping stdout renderer configuration features SPI-gated.

🤖 Was this summary useful? React with 👍 or 👎

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 26.69%. Comparing base (f46200a) to head (ec6af29).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #900   +/-   ##
=======================================
  Coverage   26.69%   26.69%           
=======================================
  Files         697      697           
  Lines       48910    48910           
=======================================
+ Hits        13057    13058    +1     
+ Misses      35853    35852    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@Kyle-Ye Kyle-Ye merged commit a8bfc2a into main Jun 7, 2026
7 of 10 checks passed
@Kyle-Ye Kyle-Ye deleted the codex/fix-uitest-app-renderer-configuration branch June 7, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: app-scene App, scene, window, commands, storage, and lifecycle APIs. type: bug Something is not working correctly.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant