Fix App renderer configuration default visibility#900
Merged
Conversation
Member
Author
|
/uitest macos |
🤖 Augment PR SummarySummary: Makes the default 🤖 Was this summary useful? React with 👍 or 👎 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #900 +/- ##
=======================================
Coverage 26.69% 26.69%
=======================================
Files 697 697
Lines 48910 48910
=======================================
+ Hits 13057 13058 +1
+ Misses 35853 35852 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent Summary
Make the default
App.rendererConfigurationimplementation visible to regular OpenSwiftUI imports soTestingHostAppcan satisfyAppwithout adding a local override.The stdout renderer configuration requirement remains SPI-gated, while the default
nilwitness is available for conforming app types. This fixes the UI test host build regression after #893 whenOSUI_UITestsimportsTestingHost.Validation
./setup.shfromExamplexcodebuild -workspace Example/Example.xcworkspace -scheme OSUI_UITests -destination 'generic/platform=iOS Simulator' -configuration OpenSwiftUIDebug build CODE_SIGNING_ALLOWED=NO