-
Notifications
You must be signed in to change notification settings - Fork 9
feat(gh-actions): release.yml for publishing and versioning
#227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
release.yml for publishing and versioning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tirumerla could you please review this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tirumerla could you please review this change?
0xisk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tirumerla Could you please review the main parts that are related to the release process? Please note that this PR is behind this #221 so that is why it looks big. Thanks
| commit: 'chore: version packages' | ||
| title: 'chore: version packages' | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@son-oz do we want to use the OZ release app here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@0xisk - I see we're doing both version and publish at the same time. What happens when changesets exists? Will it skip publish?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@son-oz do we want to use the OZ release app here?
We should
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@0xisk - I see we're doing both version and publish at the same time. What happens when changesets exists? Will it skip publish?
Yes it will. What do you think about that behavior?
|
I can re-run the StepSecurity hardening to pin the hashes after this is merged. |
93dbe16 to
9f629db
Compare
Blocked by #221