Skip to content

Conversation

@0xisk
Copy link
Member

@0xisk 0xisk commented Oct 21, 2025

Blocked by #221

@0xisk 0xisk changed the title refactor: bump Comapct version 0.26.0 feat(gh-actions): release.yml for publishing and versioning Oct 21, 2025
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tirumerla could you please review this change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tirumerla could you please review this change?

Copy link
Member Author

@0xisk 0xisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tirumerla Could you please review the main parts that are related to the release process? Please note that this PR is behind this #221 so that is why it looks big. Thanks

commit: 'chore: version packages'
title: 'chore: version packages'
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@son-oz do we want to use the OZ release app here?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xisk - I see we're doing both version and publish at the same time. What happens when changesets exists? Will it skip publish?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@son-oz do we want to use the OZ release app here?

We should

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xisk - I see we're doing both version and publish at the same time. What happens when changesets exists? Will it skip publish?

Yes it will. What do you think about that behavior?

@son-oz
Copy link
Contributor

son-oz commented Nov 6, 2025

I can re-run the StepSecurity hardening to pin the hashes after this is merged.

@0xisk 0xisk marked this pull request as ready for review December 1, 2025 10:09
@0xisk 0xisk requested a review from a team as a code owner December 1, 2025 10:09
@0xisk 0xisk requested a review from son-oz December 3, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants