Add JavaScript extensions#264
Conversation
|
@rderooij Sorry for not getting back to you earlier on this PR. First of all, thanks for the suggestion to integrate a fork of that extension into the OOTBee Support Tools. Since I personally have never used that addon (it adds functionality I found potentially problematic or going beyond what I thought "should" be made available), I am not that familiar with its current compability state. In case we go ahead (the original project is dead), could I ask you to apply the common code style used in this project to your contribution? Alternatively, if you were to allow reviewers to push changes to your PR branch, I could apply the code style and additional cleanup (removing commented code, logging and/or config improvements, ...) before doing the actual merge. |
|
I have updated the code based on the style guide. The original project latest release was in 2017. There is a 1.8 release from 2021 in Maven, but it is no longer compatible with recent versions of ACS. The rationale in my view is that jconsole is part of OOTBee, so why not make jconsole more useful with some extra root objects. I did not try to create a pull request to the original creator. I could try that first to validate whether the project is 'dead'. |
|
Since I have a long weekend with Monday off and you provided #272 last week, I managed to take some time to work with this PR locally. The following are the things I noticed:
Since the PR branch is not writeable to me, how'd you like to receive suggestions / changes from me on how to solve the library / API incompatibilities, which would be the primary blocker for merging for me at the moment? |
Integrated the Alfresco JavaScript Extensions (from alfresco-jscript-extensions by jgoldhammer) into OOTBee Support Tools. This PR adds several new root objects to the JavaScript API.