Skip to content

[refactor] use new api container lifecycle bench - #348

Draft
mathewjhan wants to merge 2 commits into
refactor/move-controller-to-localfrom
refactor/benchmark-container-lifecycle
Draft

[refactor] use new api container lifecycle bench#348
mathewjhan wants to merge 2 commits into
refactor/move-controller-to-localfrom
refactor/benchmark-container-lifecycle

Conversation

@mathewjhan

@mathewjhan mathewjhan commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

What

Why

How to Test

Checklist

  • PR title follows [module] type: description format
    (labels are derived from it automatically — no need to add them by hand)
  • ruff check . and ruff format --check . pass
  • pyright osmosis_ai/ passes
  • pytest passes (new tests added if applicable)
  • Public API changes are documented
  • No secrets or credentials included

Summary by cubic

Refactors the container lifecycle benchmark to use the RolloutClient API instead of a custom controller server.

  • Removes the in-benchmark controller app that received completion callbacks.
  • Submits rollouts through RolloutClient.run_rollout_async and waits on the returned future.
  • Keeps the same timeout behavior by doubling the per-rollout timeout to cover both agent and grader.

Written for commit 48aee7b. Summary will update on new commits.

Review in cubic

@mathewjhan
mathewjhan force-pushed the refactor/benchmark-container-lifecycle branch from b99dffc to 48aee7b Compare September 4, 2026 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant