[refactor] use new api container lifecycle bench - #348
Draft
mathewjhan wants to merge 2 commits into
Draft
Conversation
mathewjhan
force-pushed
the
refactor/benchmark-container-lifecycle
branch
from
September 4, 2026 02:49
b99dffc to
48aee7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
How to Test
Checklist
[module] type: descriptionformat(labels are derived from it automatically — no need to add them by hand)
ruff check .andruff format --check .passpyright osmosis_ai/passespytestpasses (new tests added if applicable)Summary by cubic
Refactors the container lifecycle benchmark to use the
RolloutClientAPI instead of a custom controller server.RolloutClient.run_rollout_asyncand waits on the returned future.Written for commit 48aee7b. Summary will update on new commits.