feat: allow conditional survey items to reference participant variables - #1161
Open
jacyanthis wants to merge 5 commits into
Open
feat: allow conditional survey items to reference participant variables#1161jacyanthis wants to merge 5 commits into
jacyanthis wants to merge 5 commits into
Conversation
Contributor
Author
jacyanthis
force-pushed
the
variable-conditions
branch
2 times, most recently
from
June 21, 2026 23:43
a235329 to
554905d
Compare
Stage names previously rendered template variables literally; only stage descriptions were resolved. Resolve the stage name in the base resolveTemplateVariablesInStage (so it applies in agent prompt stage context and any resolved-stage view), and render the resolved name in the participant-facing header and side nav via a shared resolveStageName helper that merges experiment/cohort/participant value maps. Missing variables render as an empty string, matching prompt and description behavior. Names without template syntax are unchanged.
jacyanthis
force-pushed
the
variable-conditions
branch
from
June 22, 2026 02:28
554905d to
20d00ab
Compare
jacyanthis
force-pushed
the
variable-conditions
branch
from
July 6, 2026 18:28
20d00ab to
bc948b2
Compare
Collaborator
|
@jacyanthis Please resolve conflicts and re-upload |
Contributor
Author
|
I updated the branch with main, but it will likely become outdated again soon. Manual testing per template: Set up an experiment with (i) a participant with a variable (e.g.,
|
jimbojw
requested changes
Jul 20, 2026
jimbojw
left a comment
jimbojw
left a comment
Collaborator
There was a problem hiding this comment.
No comments on the code proper, but I'd like to see some unit tests. At least for the utils/ and functions/ code. Unit tests for frontend/ are probably not necessary since it's all components (not standalone utility code).
Contributor
Author
|
Tests added, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allows experimenters to make survey items conditionally appear not just based on responses to prior survey items (existing functionality) but also participant variables. For example, a survey question can only appear if a participant is in a certain treatment group. Variables appear under a protected "Variables" Stage ID.
Example