Maigration/chpc module#130
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughMigration adds nine CPHC assessment tables (oral_health, pain_symptom_assessment, psychosocial_caregiver_support, nose_diagnosis_assessment, throat_diagnosis_assessment, opthalmic_visit, ear_diagnosis_assessment, elderly_health_assessment, mental_health_screening) with primary keys, patient/visit linkage columns, domain-specific nullable fields, and indexes/uniques as declared. ChangesCPHC Health Assessment Tables
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/main/resources/db/migration/dbiemr/V82__cphc_module_migration.sql`:
- Around line 55-57: Several tables (pain_symptom_assessment, opthalmic_visit,
ear_diagnosis_assessment) declare `beneficiary_id` and `beneficiary_reg_id` as
mediumtext which is inconsistent with the rest of the migration where these
columns are bigint; change those column definitions to use `bigint` (e.g.,
`beneficiary_id bigint DEFAULT NULL`, `beneficiary_reg_id bigint DEFAULT NULL`)
instead of mediumtext and remove any text collation clauses, and apply the same
replacement for the other occurrences noted (the other blocks around the
commented ranges) so all tables use the same bigint type for `beneficiary_id`
and `beneficiary_reg_id`.
- Around line 19-20: The migration defines `created_date` and `updated_date` on
the oral_health table as mediumtext which diverges from the rest of V82 and
forces special-case parsing; update the column definitions in
V82__cphc_module_migration.sql for the oral_health table by changing
`created_date` and `updated_date` to a numeric epoch-ms type (bigint) consistent
with sibling assessment tables, removing the text/collation attributes so audit
timestamps are stored as BIGINT epoch milliseconds and behave the same as other
tables.
- Line 6: Change the oral_health.ben_visit_no column to NOT NULL so the
uq_oral_health_patient_visit unique constraint on (patient_id, ben_visit_no) can
prevent duplicates: update the migration SQL to alter the column definition from
"`ben_visit_no` int DEFAULT NULL" to a NOT NULL integer (e.g., "`ben_visit_no`
int NOT NULL"), and before applying the DDL ensure any existing NULL
ben_visit_no rows are backfilled or removed (update records to a valid value or
delete) so the ALTER TABLE succeeds; reference the oral_health.ben_visit_no
column and the uq_oral_health_patient_visit unique index when making the change.
- Line 3: Replace the non-failing "CREATE TABLE IF NOT EXISTS" statements in the
V82__cphc_module_migration.sql migration (e.g., the oral_health table and the
other tables created on the noted lines) with plain "CREATE TABLE" statements so
the migration fails fast on schema drift; do not add ALTERs in this file—if you
need to reconcile existing tables, create a separate follow-up migration that
explicitly alters or verifies those existing schemas instead of silencing
failures here.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 3306c038-9b46-48e8-8931-21b2b631202c
📒 Files selected for processing (1)
src/main/resources/db/migration/dbiemr/V82__cphc_module_migration.sql
|
paras-dba
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Description
JIRA ID: AMM-2232
Please provide a summary of the change and the motivation behind it. Include relevant context and details.
✅ Type of Change
ℹ️ Additional Information
Please describe how the changes were tested, and include any relevant screenshots, logs, or other information that provides additional context.
Summary by CodeRabbit