Refactor: Modernize SocketService, remove hardcoded URL, and update RxJS#79
Refactor: Modernize SocketService, remove hardcoded URL, and update RxJS#79Anurag-elitx wants to merge 1 commit into
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📋 Description
JIRA ID: #130
This PR modernizes the
SocketServiceby addressing legacy patterns that hinder the migration to Angular 19 and RxJS 7+.Key Changes:
http://10.208.122.38:4000/out of the service and into the environment configuration. It is now exposed viaConfigService.Observable.create()with the standardnew Observable()constructor ingetMessagesandgetDebugMessage.@Injectable()decorator and ensured that re-instantiating the socket disconnects the old one first to prevent memory leaks and duplicate listeners.SOCKET_URLtoenvironment.ci.ts.templateto guide other developers on required configuration.✅ Type of Change
ℹ️ Additional Information