Refactor: Secure sessionStorageService and update cookie attributes#80
Refactor: Secure sessionStorageService and update cookie attributes#80Anurag-elitx wants to merge 1 commit into
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📋 Description
JIRA ID: #131
This PR audits and secures the
sessionStorageServiceby addressing several security and robustness flaws identified during the audit.Key Changes:
JSON.stringifybefore encryption andJSON.parseafter decryption insetItemandgetItem. Previously, passing an object resulted in"[object Object]"being stored.environment.encKeyis empty (as it currently is inenvironment.ts), the service uses a fallback instead of failing or storing with an empty key.setCookiemethod to include the; SameSite=Laxattribute to provide CSRF protection.map,catch) to clean up the file.✅ Type of Change
ℹ️ Additional Information
getItemmethod includes atry-catchblock aroundJSON.parseto ensure backward compatibility with plain string values that might already be in the storage.