-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[Feat]: Add UVDoc dynamic graph model #4793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat]: Add UVDoc dynamic graph model #4793
Conversation
|
Thanks for your contribution! |
| return out3 | ||
|
|
||
|
|
||
| class UVDocnet(PretrainedModel): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
按照我们的命名风格,是否应该是UVDocNet或者直接UVDoc之类的?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
|
||
| return [out.cpu().numpy()] | ||
|
|
||
| def get_transpose_weight_keys(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果没有需要翻转的key,就不用重写这个方法
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| model_state_dict = self.state_dict(*args, **kwargs) | ||
|
|
||
| hf_state_dict = {} | ||
| for old_key, value in model_state_dict.items(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这段逻辑如果特别常用的话,可以评估一下是否抽出来放在一个公共的地方,各个模型都可以调用。比如考虑封装成函数或者mixin的形式。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
|
||
|
|
||
| class HFStateDictMixin: | ||
| class BNHFStateDictMixin: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
建议写BatchNorm吧,更清晰一些
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
No description provided.