ci: warm buildkit cache from parent ref on PRs and branches - #26
Merged
Conversation
Per-ref buildcache (`:buildcache-${ref}`) is cold for first-time
PRs and feature-branch pushes. Shared `:buildcache` lags behind
because it only updates on default-branch builds, so during
active feature-branch development (e.g. successive LLVM bumps on
their own branch) every retry rebuilt against stale main layers.
Add a parent cache-from layer:
- PR -> `:buildcache-${base_ref}` (PR target branch)
- non-default branch push -> `:buildcache-${default_branch}`
- default branch push / tag -> none (shared :buildcache covers it)
Applies to both `salt-dev` and `salt-dev-tools` images.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per-ref buildcache (
:buildcache-${ref}) is cold for first-time PRs and feature-branch pushes. Shared:buildcachelags behind because it only updates on default-branch builds, so during active feature-branch development (e.g. successive LLVM bumps on their own branch) every retry rebuilt against stale main layers.Add a parent cache-from layer:
:buildcache-${base_ref}(PR target branch):buildcache-${default_branch}Applies to both
salt-devandsalt-dev-toolsimages.