add supplier SPN linking for BOM import #1209
Open
+214
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add automatic part linking via supplier part numbers (SPNs) in the BOM importer. When a Part-DB ID is not provided, the importer now searches for existing parts by matching supplier SPNs from the CSV with orderdetail records in the database. This allows automatic part linking when KiCad schematic BOMs contain supplier information like LCSC SPN, Mouser SPN, etc., improving the import workflow for users who track parts by supplier part numbers.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1209 +/- ##
============================================
+ Coverage 58.23% 58.26% +0.02%
- Complexity 7435 7442 +7
============================================
Files 582 582
Lines 23656 23680 +24
============================================
+ Hits 13775 13796 +21
- Misses 9881 9884 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the BOM import functionality, specifically improving how supplier part numbers (SPNs) are used to automatically link BOM entries to existing parts in the database.
Improvements to BOM import logic:
In my opinion, there is no reason not to match a part when a supplier SPN provided by the user does match to something already in the DB.
A lot of people have for example LCSC SPN's in their BOM's.
Automatically linking matched parts greatly simplifies the project creation workflow!
I for example would use this a lot even while still working on the project, to make sure I have all the needed parts early in the process!
If you have a different opinion on it, feel free to tell me :)
I'm willing to make changes if requested :)
Note: I'm not able to execute the PHP tests locally. While I did deploy the code on my server and it did work, I have not yet executed the tests. I therefore hope for them to pass on your CI :)