This repository was archived by the owner on Jun 3, 2024. It is now read-only.
Add the patchwork-god-classes module#127
Merged
TheGlitch76 merged 2 commits intomasterfrom Jul 16, 2020
Merged
Conversation
kitlith
force-pushed
the
event-dispatcher-module
branch
from
b25b522 to
15b9ca9
Compare
Contributor
Author
|
A note. patchwork-events-lifecycle has ServerLifecycleHooks, which is in a vein similar to these classes, but I think it can be handled entirely within that module so I don't think it needs to move here. Similarly, patchwork-networking has NetworkHooks, which I also don't think needs to move here. (however, ServerLifecycleHooks is missing method implementations at the very least) |
Contributor
Author
|
renamed to patchwork-god-classes as per discussion in discord, though I'm still open to other names. |
kitlith
changed the title
This was referenced Jul 13, 2020
This was referenced Jul 15, 2020
TheGlitch76
approved these changes
Jul 16, 2020
Member
TheGlitch76
left a comment
TheGlitch76
left a comment
There was a problem hiding this comment.
Name is a total meme but it can be changed later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
splitting this out from #115 so that future PRs can implement methods on these classes directly, instead of #115 and/or #121 requiring a rebase + a commit to add new events/methods.
Also means we get to bikeshed the module, documentation, and what classes it's going to contain on its own, rather than bundling that with a bunch of implementation.