web: show guest-agent IP in VM Hardware box#401
Conversation
Review Summary by QodoDisplay guest-agent IP addresses in VM Hardware panel
WalkthroughsDescription• Adds IP address row to VM Hardware panel from QEMU guest agent • Displays guest agent reported IP addresses in monospace format • Only renders for running QEMU VMs with guest agent data • Matches existing CPU/Memory/Network row styling with Globe icon Diagramflowchart LR
A["VM Hardware Panel"] --> B["Check: isQemu && isRunning"]
B --> C["Check: guestInfo.ip_addresses exists"]
C --> D["Render IP Row"]
D --> E["Display with Globe icon & monospace font"]
File Changes1. web/src/vm_modals.js
|
Code Review by Qodo
1.
|
There was a problem hiding this comment.
Pull request overview
Mirrors QEMU guest-agent–reported IP addresses into the existing “VM Hardware” panel on the VM detail view, so IPs appear alongside CPU/Memory/Disk/Network for running QEMU VMs when available.
Changes:
- Adds a new “IP” row (Globe icon + monospace value) to the VM Hardware panel.
- Conditionally renders the row only for running QEMU VMs with
guestInfo.ip_addressespopulated.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
737ab0e to
9c5a89f
Compare
Add an IP row inside the VM Hardware panel that displays the addresses reported by the QEMU guest agent. Renders only for running QEMU VMs that have ip_addresses populated, matching the style of the existing CPU/Memory/Network rows.
Constrain the IP value span to flex-1 min-w-0 and allow break-all so multi-address (IPv4 + IPv6) results from the guest agent wrap instead of overflowing the Hardware panel. Switch the row to items-start with a small top offset on the icon so it aligns with the first line when the value wraps. Add a title tooltip with the full joined list.
9c5a89f to
55dccb8
Compare
|
Hey @sacalito — thanks for this, and sorry it sat a while. The guest-agent IP row actually landed independently via #560 (shipped in v0.9.13.2): the VM detail views now render No pressure at all, but if PegaProx is useful to you, opencollective.com/pegaprox helps keep the lights on. — Marcus |
Summary
guestInfo.ip_addresses).titletooltip showing the full joined list.The same data was already exposed in the separate Guest Agent Info card to the right; this PR mirrors it into the Hardware panel so it sits alongside the other per-VM resources.
Test plan
qemu-guest-agentinstalled — IP row appears under Network inside VM Hardware.isQemu).