Use ionicons web components #894
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #894 +/- ##
==========================================
+ Coverage 47.76% 47.79% +0.02%
==========================================
Files 351 351
Lines 11292 11292
Branches 1889 1889
==========================================
+ Hits 5394 5397 +3
+ Misses 5709 5702 -7
- Partials 189 193 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
slifty
commented
Jan 16, 2026
| @@ -1,24 +1 @@ | |||
| .ion-custom-folder-move { | |||
Contributor
Author
There was a problem hiding this comment.
It looks like these styles weren't actually being used anywhere.
slifty
force-pushed
the
893-ionicons-web-components
branch
from
ebdb2fe to
8c541e3
Compare
slifty
force-pushed
the
893-ionicons-web-components
branch
from
8c541e3 to
f28de58
Compare
slifty
force-pushed
the
893-ionicons-web-components
branch
from
f28de58 to
be10eb6
Compare
We were using embedded SCSS from ionicons instead of their recommended approach which is to use web components + their npm package (though we WERE using their npm package). Issue #893 Move to ionicons web components
slifty
force-pushed
the
893-ionicons-web-components
branch
from
be10eb6 to
e30817f
Compare
aasandei-vsp
approved these changes
Jan 20, 2026
Contributor
aasandei-vsp
left a comment
aasandei-vsp
left a comment
There was a problem hiding this comment.
LGTM
- took it locally and checked, including that there are no more ion css classes
- checked the schema imports
- noticed the other icon libraries Dan was talking about, which is not great. I think trying to replace icons organically to just use ionicons, at least in the old code, that would be great.(note to Andreea)
Contributor
Author
|
Closing this in favor of #904 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way we use
ioniconsto use their web component library. This allows us to remove packaged vendor scss and also means that our application will benefit from tree-shaking / won't include icons that aren't being used in the code base.This PR does update to the most recent ionicons (we were using v4, and it is now v8). For the most part the icons are very visually similar, but there are some cases (e.g. folder) where you will notice a difference if you look side-by-side.
Resolves #893