[PER-10392] Update folder with children endpoint #903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #903 +/- ##
==========================================
+ Coverage 47.83% 48.08% +0.24%
==========================================
Files 351 351
Lines 11292 11293 +1
Branches 1889 1898 +9
==========================================
+ Hits 5402 5430 +28
+ Misses 5698 5667 -31
- Partials 192 196 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…dpoint The endpoint getLeanItems is from the old api and is quite slow, so we will be using the endpoint from the new api /folder/<folderId>/children instead. The only place it is used is the data service, so the observable will be transforming into a promise, which was what the fetchLeanItems method needed anyways.
aasandei-vsp
force-pushed
the
PER-10392-update-folder-with-children-endpoint
branch
4 times, most recently
from
d321190 to
d3b69c3
Compare
… edit The profile edit component is used for fillind the profile information and the folder children endpoint provides the data for that. Because the old one had some different property names, thumbnailURL needs mapping and the archiveNbr is actually archiveNumber in the new endpoint. Because of the archive number mismatch, the banner does not update at the moment. Issue: PER-10392 Stop using folder/getLeanItems
aasandei-vsp
force-pushed
the
PER-10392-update-folder-with-children-endpoint
branch
from
d3b69c3 to
0829f95
Compare
aasandei-vsp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves isssue: https://permanent.atlassian.net/browse/PER-10392
STEPS TO TEST:
Private workspace
EXPECTED: All files are loading correctly and can be previewed
Record preview
EXPECTED: The file preview appears
EXPECTED: All files should preview correctly.
Change profile information for archive
EXPECTED: All filled data will remain in the form(especially the image and the banner)
EXPECTED: All the data filled at steps 3,4 and 5 is still there(especially the image and the banner)
EXPECTED: All the data filled at steps 3,4 and 5 is still there(especially the image and the banner)