Skip to content

[PER-10397] Update endpoints for getting an existing share link#919

Merged
aasandei-vsp merged 3 commits intomainfrom
PER-10397-get-share-link-record-folder
Feb 23, 2026
Merged

[PER-10397] Update endpoints for getting an existing share link#919
aasandei-vsp merged 3 commits intomainfrom
PER-10397-get-share-link-record-folder

Conversation

@aasandei-vsp
Copy link
Contributor

@aasandei-vsp aasandei-vsp commented Feb 9, 2026

STEPS TO TEST:

Record share link:

  1. Log in or create account
  2. Upload a file
  3. Create a share link
  4. Close the modal and refresh the page
  5. Go back to the uploaded file and open the share link modal again.
    EXPECTED: The existing share link is populated.
  6. Copy the share link
  7. Log in or create a different account, in a new browser window or incognito mode
  8. Paste the copied share link in the browser
    EXPECTED: The share cand be previewed for unlisted or can accept share for restricted

Folder share link:

  1. Log in or create account
  2. Upload a file
  3. Create a share link
  4. Close the modal and refresh the page
  5. Go back to the uploaded file and open the share link modal again.
    EXPECTED: The existing share link is populated.
  6. Copy the share link
  7. Log in or create a different account, in a new browser window or incognito mode
  8. Paste the copied share link in the browser
    EXPECTED: The share cand be previewed for unlisted or can accept share for restricted

ISSUE: PER-10397

@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.47%. Comparing base (b3c9c11) to head (c9da30a).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #919      +/-   ##
==========================================
+ Coverage   48.25%   48.47%   +0.21%     
==========================================
  Files         350      350              
  Lines       11320    11331      +11     
  Branches     1892     1895       +3     
==========================================
+ Hits         5463     5493      +30     
+ Misses       5667     5649      -18     
+ Partials      190      189       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aasandei-vsp aasandei-vsp force-pushed the PER-10397-get-share-link-record-folder branch from 8fe3f35 to 8b0db1d Compare February 9, 2026 09:40
Copy link
Member

@cecilia-donnelly cecilia-donnelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks great 👍

@aasandei-vsp aasandei-vsp requested review from omnignorant and removed request for slifty February 16, 2026 07:14
@slifty slifty added the QA This issue is ready for QA / user acceptance testing label Feb 17, 2026
The new share-link endpoint from record can get the share link based
on the record id.

ISSUE: PER-10397
The new share-link endpoint from folder can get the share link based
on the folder id.

ISSUE: PER-10397
In order to get the share-link for an item, a call to either record
or folder will be made using the id.

ISSUE: PER-10397
@aasandei-vsp aasandei-vsp force-pushed the PER-10397-get-share-link-record-folder branch from 8b0db1d to c9da30a Compare February 20, 2026 14:32
Copy link
Member

@omnignorant omnignorant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Worked as expected.

@aasandei-vsp aasandei-vsp merged commit bce3209 into main Feb 23, 2026
15 checks passed
@aasandei-vsp aasandei-vsp deleted the PER-10397-get-share-link-record-folder branch February 23, 2026 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

QA This issue is ready for QA / user acceptance testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants