fix: implement GcpTdx and NitroEnclave support in V1 attestation#10
Merged
fix: implement GcpTdx and NitroEnclave support in V1 attestation#10
Conversation
The upstream merge left V1 AttestationV1's decode_app_info_ex and verify_with_time with bail!() stubs for GcpTdx and NitroEnclave, since upstream only has empty placeholders for these platforms. This commit adds full implementations: - decode_app_info_ex: GcpTdx uses TPM PCR-based MR computation, NitroEnclave uses NSM PCR-based MR computation - verify_with_time: GcpTdx performs TDX quote + TPM quote verification with PCR replay, NitroEnclave performs COSE signature + cert chain verification All callers (guest-agent, KMS, verifier, ra-rpc) use into_v1() and were broken on these platforms without this fix.
The test requires vsock kernel support which is not available in GitHub Actions runners.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AttestationV1::decode_app_info_exandverify_with_timewithbail!()stubs for GcpTdx and NitroEnclave, since upstream only has empty placeholders for these platformsdecode_app_info, TDX + TPM dual verification with PCR replay forverify_with_timedecode_app_info, COSE signature + cert chain verification forverify_with_timeinto_v1()and were broken on GcpTdx/NitroEnclave without this fixTest plan
cargo check --all-featurespassescargo clippypasses