Skip to content

Use ChangemakerFieldValues for gold data #2190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
slifty merged 3 commits into from
Jan 8, 2026
Merged

Use ChangemakerFieldValues for gold data #2190

slifty merged 3 commits into from
Jan 8, 2026

Conversation

@slifty
Copy link
Member

@slifty slifty commented Jan 6, 2026

This PR updates our system to incorporate ChangemakerFieldValues when calculating gold data for a Changemaker.

It also introduces the concept of FieldValueBase which reflects the common elements of any type of FieldValue.

Resolves #2137

@slifty slifty force-pushed the 2137-use-changemaker-field-values branch from 87ad5e4 to 37adc9f Compare January 6, 2026 16:02
@codecov
Copy link

codecov bot commented Jan 6, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.22%. Comparing base (70b8539) to head (fefbf3a).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2190   +/-   ##
=======================================
  Coverage   93.21%   93.22%           
=======================================
  Files         324      324           
  Lines        3772     3776    +4     
  Branches      557      557           
=======================================
+ Hits         3516     3520    +4     
  Misses        256      256

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@slifty slifty force-pushed the 2137-use-changemaker-field-values branch from 37adc9f to c5cd321 Compare January 6, 2026 16:40
@slifty slifty requested review from bickelj and hminsky2002 January 7, 2026 16:19
Base automatically changed from 2174-fix-erd to main January 7, 2026 18:05
hminsky2002
hminsky2002 approved these changes Jan 7, 2026
View reviewed changes
Copy link
Contributor

@hminsky2002 hminsky2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing here and this seems like a reasonable extension of our current initialization query. I do think @bickelj's insight would be valuable here, but approving this from a technical standpoint!

slifty added 3 commits January 7, 2026 13:38
@slifty
Document CHANGELOG.md maintenance
20063bd 
If an LLM agents helps us make a change to the API we want it to also
update the CHANGELOG appropriately to reflect those updates.
@slifty
Use a common FieldValueBase
f8ac00f 
We recently introduced a new type of FieldValue
(`ChangemakerFieldValue`) without making the common overlap explicit.
This change makes it clear what it means for something to be
a FieldValue.
@slifty
Incorporate ChangemakerFieldValues in gold data
fefbf3a 
When loading a `Changemaker` we want to use all types of field value
when reporting the best "value" for a given organizational base field.

Issue #2137 Include ChangemakerFieldValue data in changemaker "gold" data
@slifty slifty force-pushed the 2137-use-changemaker-field-values branch from c5cd321 to fefbf3a Compare January 7, 2026 18:38
@slifty
Copy link
Member Author

slifty commented Jan 8, 2026

I tested this somewhat locally by adding ChangemakerFieldValue data, loading the changemaker, and seeing the data.

More robust testing of more varied cases would be a good idea before we truly declare this ready for consumption, but I believe this is good enough to merge and we can rapidly fix if there is an edge case not caught.

@slifty slifty merged commit dcf3026 into main Jan 8, 2026
15 checks passed
@slifty slifty deleted the 2137-use-changemaker-field-values branch January 8, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hminsky2002 hminsky2002 hminsky2002 approved these changes

@bickelj bickelj Awaiting requested review from bickelj

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Include ChangemakerFieldValue data in changemaker "gold" data

3 participants

@slifty @hminsky2002