Use gold schema for tests #2193
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slifty
force-pushed
the
2167-use-gold-schema-for-stests
branch
3 times, most recently
from
6a732aa to
9c81894
Compare
slifty
force-pushed
the
2167-use-gold-schema-for-stests
branch
from
9c81894 to
21efd0e
Compare
Member
Author
|
It looks like a test is failing -- I'm betting something about our mocking is leaking between parallel tests. This PR is currently somewhat in "proof of concept" mode, so what I think I'll do is clean up the gold data portion of this implementation and then make sure our tests support parallelization. I may break that into two PRs, or maybe keep it as one with mutliple commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not ready for review but I wanted to show it off for now.
It moves our tests to use a gold schema instead of running migrations for every test. This is faster out of the box, but also it allows us to run our integration tests in parallel (since the migration library had a limitation forcing us to run in band).
What once took 5 minutes will now take... much less than that (TBD let's see)!