-
-
Notifications
You must be signed in to change notification settings - Fork 125
Weekly Regular Documentation Revisions 25.12.29-26.01.04 - develop #2021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Weekly Regular Documentation Revisions 25.12.29-26.01.04 - develop #2021
Conversation
allow to set display duration for BannerType
…without JPEG compression).
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
📝 WalkthroughWalkthroughDocumentation and localization updates: formatting adjustments in New-or-Enhanced-Logics.md, changelog reorganization in Whats-New.md moving "Toggle per-target warhead effects apply timing" from fixes to new features, and addition of Chinese translations with metadata updates across multiple .po files. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
Pre-merge checks✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docs/locale/zh_CN/LC_MESSAGES/New-or-Enhanced-Logics.po (1)
2632-2659: New “per‑target warhead effects timing” translation is accurate; fix minor comment labelThe new zh_CN content for “Toggle per-target warhead effects apply timing” is technically faithful and reads well, including the explanation of behavior changes and the edge‑case notes about
CellSpreadandCrit.*flags.One minor doc correctness nit in the rules snippet for both English and Chinese:
- Line
[CombatDamage] ; WarheadTypeis misleading:[CombatDamage]is a global rules section, not aWarheadType.Consider changing that comment in both msgid and msgstr to something like:
Suggested diff in this entry
-[CombatDamage] ; WarheadType +[CombatDamage] ; sectionEverything else in this block (option name, default description, and Chinese wording) looks good.
🧹 Nitpick comments (1)
docs/locale/zh_CN/LC_MESSAGES/CREDITS.po (1)
9-18: New credit and zh-CN updates look consistent; a couple of neighboring strings remain untranslated
The POT-Creation-Date update and the adjusted translations for:
- “Unit & infantry auto-conversion on ammo change” → “基于弹药量的自动变形”
- “Fix the bug that ai will try to product aircraft even the airport has no free dock for it” → “修复了即便在没有可用的空余机位时 AI 也仍会尝试生产战机的 Bug”
- “Fix an issue where non-repairer units needed sensors to attack cloaked friendly units” → “修复了非维修单位需要能够反隐才能攻击友军隐形单位的问题”
- “Allow customizing whether to synchronously change the owner of the RadioLink-linked units when the owner of a building changes” → “允许自定义单位是否会在其所连接建筑发生所属变更时同步变更所属”
all read naturally and match the English intent.The new credit line “Toggle per-target warhead effects apply timing” → “设置按目标生效的弹头效果应用时机” is semantically correct and aligned with the feature name used in other docs.
Minor optional follow-up: the credits for “CellSpread in cylinder shape” and “CellSpread damage check if victim is in air or on floor” nearby still have empty
msgstrentries; consider filling those in a later localization pass to keep the CREDITS page fully translated.Also applies to: 157-158, 471-472, 659-661
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
docs/New-or-Enhanced-Logics.mddocs/Whats-New.mddocs/locale/zh_CN/LC_MESSAGES/CREDITS.podocs/locale/zh_CN/LC_MESSAGES/New-or-Enhanced-Logics.podocs/locale/zh_CN/LC_MESSAGES/User-Interface.podocs/locale/zh_CN/LC_MESSAGES/Whats-New.po
🔇 Additional comments (6)
docs/Whats-New.md (1)
343-476: Reclassifying per-target warhead timing under “New” looks correctListing “Toggle per-target warhead effects apply timing” in the New section (and not under vanilla fixes) matches it being a new configurable toggle rather than a pure bugfix; the link target and naming are consistent with the referenced logic doc.
docs/locale/zh_CN/LC_MESSAGES/User-Interface.po (1)
1659-1664: Chinese translation typo fix is accurateThe updated phrase “更美观且位置正确的标记” correctly reflects “prettier and more correctly placed markers” and fixes the previous typo; no further changes needed.
docs/locale/zh_CN/LC_MESSAGES/New-or-Enhanced-Logics.po (3)
11-18: Metadata POT date bump is fine
POT-Creation-Dateupdate looks like a normal sync with the latest POT; no issues.
721-728: Updated source line references look consistentThe extended
#:reference list (new2625+entries) correctly reflects added content inNew-or-Enhanced-Logics.md. Nothing to change here.
1069-1072: Image reference list adjustment is benignAdditional
#:entries for the genericimagemsgid are just line-number/anchor shifts from upstream docs; translations remain unchanged and correct.docs/New-or-Enhanced-Logics.md (1)
2632-2661: LGTM — Feature documentation is comprehensive and well-structured.The "Toggle per-target warhead effects apply timing" section is well-documented with:
- Clear explanation of the feature purpose and behavior
- Proper configuration examples showing both global and per-warhead settings
- Detailed list of affected effects with accurate cross-references
- Appropriate warning and note blocks
The documentation integrates well with the existing style and structure of the file.
e25cdec to
90d1c36
Compare
For non-urgent documentation modifications, they should now be submitted through this dedicated Pull Request and will undergo weekly batch merging.
Documentation changes associated with other feature/bugfix pull requests should remain within their respective Pull Requests.
For example: If a Pull Request gets merged into the main branch without completing required documentation updates, the content should first be synchronized to this dedicated documentation branch. Subsequent corrections will then be made within this dedicated documentation Pull Request.
Summary by CodeRabbit
Release Notes
Documentation
Localization
✏️ Tip: You can customize this high-level summary in your review settings.