Skip to content

Conversation

@DeathFishAtEase
Copy link
Collaborator

@DeathFishAtEase DeathFishAtEase commented Dec 28, 2025

For non-urgent documentation modifications, they should now be submitted through this dedicated Pull Request and will undergo weekly batch merging.

Documentation changes associated with other feature/bugfix pull requests should remain within their respective Pull Requests.

For example: If a Pull Request gets merged into the main branch without completing required documentation updates, the content should first be synchronized to this dedicated documentation branch. Subsequent corrections will then be made within this dedicated documentation Pull Request.


对于并不急需的文档修改现改为使用这个拉取请求进行提交,每周进行一次合并。

对于其他拉取请求中的文档修改则跟随其拉取请求。

例如某个拉取请求在合并前没有处理完毕文档问题,那么在它合并到主分支后,将内容更新到这个拉取请求所在的分支,然后在这个拉取请求所在的分支进行进一步更正

Summary by CodeRabbit

Release Notes

  • Documentation

    • Documented new feature: "Toggle per-target warhead effects apply timing" for enhanced control over warhead effect application.
    • Improved documentation formatting and structure for better readability.
  • Localization

    • Expanded Chinese (Simplified) translations for game features, gameplay logic, and interface elements.
    • Enhanced translation accuracy and consistency across documentation.

✏️ Tip: You can customize this high-level summary in your review settings.

DeathFishAtEase and others added 30 commits July 14, 2025 00:48
FireUp.ResetInRetarget
allow to set display duration for BannerType
@DeathFishAtEase DeathFishAtEase self-assigned this Dec 28, 2025
@DeathFishAtEase DeathFishAtEase added the No Documentation Needed No documentation needed whatsoever label Dec 28, 2025
@github-actions
Copy link

github-actions bot commented Dec 28, 2025

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@coderabbitai
Copy link

coderabbitai bot commented Jan 1, 2026

📝 Walkthrough

Walkthrough

Documentation and localization updates: formatting adjustments in New-or-Enhanced-Logics.md, changelog reorganization in Whats-New.md moving "Toggle per-target warhead effects apply timing" from fixes to new features, and addition of Chinese translations with metadata updates across multiple .po files.

Changes

Cohort / File(s) Summary
Documentation Formatting
docs/New-or-Enhanced-Logics.md
Minor Markdown formatting: code-style backticks added around CellSpread references; bullet list prefix adjusted from double-dash to plus/minus notation. Content logic unchanged.
Changelog Reorganization
docs/Whats-New.md
"Toggle per-target warhead effects apply timing" entry moved from Vanilla fixes sections to New sections (removed from fixes, added under new features in two locations).
Chinese Localization: Credits
docs/locale/zh_CN/LC_MESSAGES/CREDITS.po
POT-Creation-Date updated (2025-12-26 → 2026-01-01); multiple msgstr entries populated with Chinese translations (e.g., "Unit & infantry auto-conversion" → "基于弹药量的自动变形"); new entry added for "Toggle per-target warhead effects apply timing"; line references adjusted throughout.
Chinese Localization: New Logics
docs/locale/zh_CN/LC_MESSAGES/New-or-Enhanced-Logics.po
POT-Creation-Date updated; new translated section "Toggle per-target warhead effects apply timing" added with descriptions; extensive new translation blocks for warhead, area fire, burst/delayed fire, and other features; existing translations realigned with updated line numbers.
Chinese Localization: UI
docs/locale/zh_CN/LC_MESSAGES/User-Interface.po
Single translation typo correction: "更没关且" → "更美观且" in hardcoded black dots UI message.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 Hops through docs with careful paw,
Translations flowing without a flaw,
From fixes moved to features new,
And Chinese words both old and true,
The changelog grows, the docs align,
All metadata dancing in perfect line!

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies this as a weekly documentation revision PR covering a specific date range, which directly matches the nature of the changeset.
Description check ✅ Passed The description explains the purpose of the PR, submission guidelines, and workflow for documentation changes, though it lacks specifics about what changes are included in this batch.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
docs/locale/zh_CN/LC_MESSAGES/New-or-Enhanced-Logics.po (1)

2632-2659: New “per‑target warhead effects timing” translation is accurate; fix minor comment label

The new zh_CN content for “Toggle per-target warhead effects apply timing” is technically faithful and reads well, including the explanation of behavior changes and the edge‑case notes about CellSpread and Crit.* flags.

One minor doc correctness nit in the rules snippet for both English and Chinese:

  • Line [CombatDamage] ; WarheadType is misleading: [CombatDamage] is a global rules section, not a WarheadType.

Consider changing that comment in both msgid and msgstr to something like:

Suggested diff in this entry
-[CombatDamage]                        ; WarheadType
+[CombatDamage]                        ; section

Everything else in this block (option name, default description, and Chinese wording) looks good.

🧹 Nitpick comments (1)
docs/locale/zh_CN/LC_MESSAGES/CREDITS.po (1)

9-18: New credit and zh-CN updates look consistent; a couple of neighboring strings remain untranslated

  • The POT-Creation-Date update and the adjusted translations for:

    • “Unit & infantry auto-conversion on ammo change” → “基于弹药量的自动变形”
    • “Fix the bug that ai will try to product aircraft even the airport has no free dock for it” → “修复了即便在没有可用的空余机位时 AI 也仍会尝试生产战机的 Bug”
    • “Fix an issue where non-repairer units needed sensors to attack cloaked friendly units” → “修复了非维修单位需要能够反隐才能攻击友军隐形单位的问题”
    • “Allow customizing whether to synchronously change the owner of the RadioLink-linked units when the owner of a building changes” → “允许自定义单位是否会在其所连接建筑发生所属变更时同步变更所属”
      all read naturally and match the English intent.
  • The new credit line “Toggle per-target warhead effects apply timing” → “设置按目标生效的弹头效果应用时机” is semantically correct and aligned with the feature name used in other docs.

  • Minor optional follow-up: the credits for “CellSpread in cylinder shape” and “CellSpread damage check if victim is in air or on floor” nearby still have empty msgstr entries; consider filling those in a later localization pass to keep the CREDITS page fully translated.

Also applies to: 157-158, 471-472, 659-661

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7541a51 and b96d8db.

📒 Files selected for processing (6)
  • docs/New-or-Enhanced-Logics.md
  • docs/Whats-New.md
  • docs/locale/zh_CN/LC_MESSAGES/CREDITS.po
  • docs/locale/zh_CN/LC_MESSAGES/New-or-Enhanced-Logics.po
  • docs/locale/zh_CN/LC_MESSAGES/User-Interface.po
  • docs/locale/zh_CN/LC_MESSAGES/Whats-New.po
🔇 Additional comments (6)
docs/Whats-New.md (1)

343-476: Reclassifying per-target warhead timing under “New” looks correct

Listing “Toggle per-target warhead effects apply timing” in the New section (and not under vanilla fixes) matches it being a new configurable toggle rather than a pure bugfix; the link target and naming are consistent with the referenced logic doc.

docs/locale/zh_CN/LC_MESSAGES/User-Interface.po (1)

1659-1664: Chinese translation typo fix is accurate

The updated phrase “更美观且位置正确的标记” correctly reflects “prettier and more correctly placed markers” and fixes the previous typo; no further changes needed.

docs/locale/zh_CN/LC_MESSAGES/New-or-Enhanced-Logics.po (3)

11-18: Metadata POT date bump is fine

POT-Creation-Date update looks like a normal sync with the latest POT; no issues.


721-728: Updated source line references look consistent

The extended #: reference list (new 2625+ entries) correctly reflects added content in New-or-Enhanced-Logics.md. Nothing to change here.


1069-1072: Image reference list adjustment is benign

Additional #: entries for the generic image msgid are just line-number/anchor shifts from upstream docs; translations remain unchanged and correct.

docs/New-or-Enhanced-Logics.md (1)

2632-2661: LGTM — Feature documentation is comprehensive and well-structured.

The "Toggle per-target warhead effects apply timing" section is well-documented with:

  • Clear explanation of the feature purpose and behavior
  • Proper configuration examples showing both global and per-warhead settings
  • Detailed list of affected effects with accurate cross-references
  • Appropriate warning and note blocks

The documentation integrates well with the existing style and structure of the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No Documentation Needed No documentation needed whatsoever

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants