feat(toolbox_filter_editor): Filter Editor toolbox plugin#149
Open
pabloinigoblasco wants to merge 1 commit into
Open
feat(toolbox_filter_editor): Filter Editor toolbox plugin#149pabloinigoblasco wants to merge 1 commit into
pabloinigoblasco wants to merge 1 commit into
Conversation
pabloinigoblasco
changed the title
pabloinigoblasco
force-pushed
the
gh/filter-registry-service
branch
from
93e1dac to
8c83120
Compare
pabloinigoblasco
changed the title
pabloinigoblasco
force-pushed
the
gh/filter-registry-service
branch
from
8c83120 to
3ff8888
Compare
5 tasks
pabloinigoblasco
force-pushed
the
gh/filter-registry-service
branch
2 times, most recently
from
8e1b223 to
3e06189
Compare
Per-curve filter editor with live preview, Save (volatile read-path transform), Generate (writes a persistent derived time series), and a streaming-aware Generate continuation that keeps the derived series appending sample-by-sample as the source advances under a sliding retention window. Highlights: - Pulls the 12 built-in FilterTransform classes from the SDK via the pj.filter_registry.v1 service; the toolbox registers them through the ServiceRegistryBuilder so the host's read path uses the SAME factory instance (one source of truth for builtins). - Generate streaming continuation: per-source stateful FilterTransform clone cached in GenerateState, fed only the NEW tail each tick via appendTail — keeps MovingAverage's internal buffer warm and avoids edge-effect artifacts when the source slides through retention. - Save accepts the "none" transform too: lets the user explicitly commit a reset-to-original via Save (the host's on_data_changed sees inc_fn null for "none" and falls through to clearCurveTransform). Generate keeps the stricter isValid().
pabloinigoblasco
force-pushed
the
gh/filter-registry-service
branch
from
3e06189 to
ba6c922
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Port of PlotJuggler 3's "Apply filter to data" tool to PJ4 as a toolbox panel. Pick a source curve in the dialog, choose a transform, configure its parameters, see the result live in the preview chart, give the output a custom alias, and Save to install it on the plot — or Generate to materialise the filtered series as a new persistent topic.
Available transforms
=,<,≤,>,≥,range)Dialog features
[name][TransformName]legend.source[TransformName], user can override.Wiring
The plugin registers its 12 builtin classes into the host's filter registry at
loaderInit(via the SDKpj.filter_registry.v1service), so the host's streaming read path resolves the same instances as the dialog's preview.Stack
plotjuggler_sdkPR — Filter Editor SDK contract + registry service.Test plan
builtin_transforms_test: 1/1 pass.[Moving Average].