dolby: Make effect calls exception-safe across audioserver lifecycles

[rajdeep-3305]

• when audioserver crashes or restarts, native AudioEffect handles become uninitialized
• catch exceptions in AudioEffect getters/setters, recreate lost effects cleanly in checkEffect(), and prevent crashes in DolbyEffectService callbacks

Change-Id: I9e5089f507a1f7e8e4257d180d6684d23cd380ae

[Copilot]

🟡 Changes recommended

A swallowed exception path in DolbyAudioEffect.setIntParam() can cause Java-side enabled state to be updated even when the native parameter write fails, leading to inconsistent effect state.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR hardens Dolby audio effect interactions against audioserver crashes/restarts by making effect accessors and service callbacks more resilient and by attempting to recreate lost AudioEffect handles within the repository.

Changes:

• Wrap AudioPlaybackCallback state-apply logic in a try/catch to prevent service crashes.
• Make DolbyRepository.checkEffect() return a success flag and attempt effect recreation when control is lost or checks throw.
• Add exception handling around DolbyAudioEffect getters/setters and parameter I/O to avoid crashes from invalid native handles.

File summaries

File	Description
LunarisDolby/src/org/lunaris/dolby/service/DolbyEffectService.kt	Guards playback callback to prevent crashes when applying saved state.
LunarisDolby/src/org/lunaris/dolby/data/DolbyRepository.kt	Adds boolean effect-health check with recreation path; wraps restore/apply flows with exception safety.
LunarisDolby/src/org/lunaris/dolby/audio/DolbyAudioEffect.kt	Adds exception handling around parameter reads/writes to avoid failures from invalid native effect handles.

Review details

Suppressed comments (1)

LunarisDolby/src/org/lunaris/dolby/data/DolbyRepository.kt:72

• Same as above: swallowing exceptions from dolbyEffect.release() during the error-path recreation makes effect lifecycle failures invisible in logs. Logging the exception will help confirm whether the old handle was still valid.

            DolbyConstants.dlog(TAG, "Error checking effect: ${e.message}, recreating")
            try { dolbyEffect.release() } catch (_: Exception) {}
            try {
                dolbyEffect = createDolbyEffect()
                restoreSavedProfileIfNeeded()

• Files reviewed: 3/3 changed files
• Comments generated: 2
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.