Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
theusaf
requested changes
Mar 8, 2026
websites/B/BookJourney/metadata.json
Outdated
Comment on lines
+15
to
+16
| "logo": "https://raw.githubusercontent.com/quetrea/Activities/add-bookjourney-activity/websites/B/BookJourney/assets/logo-v2.png", | ||
| "thumbnail": "https://raw.githubusercontent.com/quetrea/Activities/add-bookjourney-activity/websites/B/BookJourney/assets/thumbnail-v2.png", |
Contributor
There was a problem hiding this comment.
Remove the assets from the PR. You can still use the assets using commit hash in the URL here.
websites/B/BookJourney/presence.ts
Outdated
Comment on lines
+60
to
+63
| { | ||
| label: 'Open BookJourney', | ||
| url: siteUrl, | ||
| }, |
Contributor
There was a problem hiding this comment.
Buttons leading to home page are not allowed
- Remove assets from PR, use commit hash URLs instead - Remove home page button (not allowed per store rules) - Use clearActivity() instead of empty setActivity() Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
theusaf
requested changes
Mar 13, 2026
| "regExp": "^https?[:][/][/]([a-z0-9-]+[.])*bookreading[.]space[/]", | ||
| "version": "1.0.0", | ||
| "logo": "https://raw.githubusercontent.com/quetrea/Activities/821ae5755/websites/B/BookJourney/assets/logo-v2.png", | ||
| "thumbnail": "https://raw.githubusercontent.com/quetrea/Activities/821ae5755/websites/B/BookJourney/assets/thumbnail-v2.png", |
Contributor
There was a problem hiding this comment.
Thumbnail should be a landscape promotional image or screenshot, not the same as the logo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new PreMiD activity for BookJourney (
bookreading.space).What’s included
websites/B/BookJourney:metadata.jsonpresence.tsassets/logo.pngassets/thumbnail.png/s/[id].#bookjourney-premid-state) and updates Rich Presence accordingly.Validation
npx pmd build BookJourney --validatepasses successfully.Acknowledgements
npm run lintScreenshots
Proof showing the creation/modification is working as expected