Skip to content

[PAYSHIP-3949] User-friendly PUI errors#1483

Open
L3RAZ wants to merge 8 commits into5.3.xfrom
feat/PAYSHIP-3949
Open

[PAYSHIP-3949] User-friendly PUI errors#1483
L3RAZ wants to merge 8 commits into5.3.xfrom
feat/PAYSHIP-3949

Conversation

@L3RAZ
Copy link
Copy Markdown
Collaborator

@L3RAZ L3RAZ commented Mar 17, 2026

No description provided.

Copy link
Copy Markdown
Contributor

@Matt75 Matt75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about handling that into CreatePayPalOrderAction::createPayPalOrder instead of directly inside the create controller.

Comment thread core/src/Order/Exception/Handler/OrderCreationExceptionHandler.php Outdated
Comment thread core/src/Order/Exception/Handler/OrderCreationExceptionHandler.php Outdated
Comment thread ps17/controllers/front/create.php Outdated
Comment thread ps17/controllers/front/create.php
Base automatically changed from feat/PAYSHIP-3945-phone to feat/PAYSHIP-3945 March 17, 2026 16:01
Base automatically changed from feat/PAYSHIP-3945 to 5.2.x March 18, 2026 11:01
@L3RAZ L3RAZ force-pushed the feat/PAYSHIP-3949 branch 2 times, most recently from 5f5f673 to 906a202 Compare April 7, 2026 13:44
@L3RAZ L3RAZ changed the base branch from 5.2.x to 5.3.x April 7, 2026 13:44
@L3RAZ L3RAZ requested a review from Matt75 April 7, 2026 13:53
Comment thread ps17/controllers/front/create.php Outdated
Comment thread ps8/controllers/front/create.php Outdated
Comment thread ps9/controllers/front/create.php Outdated
Comment thread ps17/translations/de.php Outdated
Comment thread ps17/translations/de.php Outdated
Comment thread ps9/translations/pl-PL/ModulesCheckoutPscheckout.pl-PL.xlf Outdated
Comment thread ps9/translations/pt-PT/ModulesCheckoutPscheckout.pt-PT.xlf Outdated
Comment thread ps9/translations/pt-PT/ModulesCheckoutPscheckout.pt-PT.xlf Outdated
Comment thread ps9/translations/pt-PT/ModulesCheckoutPscheckout.pt-PT.xlf Outdated
Comment thread ps9/translations/pt-PT/ModulesCheckoutPscheckout.pt-PT.xlf Outdated
Copy link
Copy Markdown
Contributor

@Matt75 Matt75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid adding new translation strings to the translation files if you are only providing the English version. This makes it harder to identify missing translations in the Back Office.

L3RAZ and others added 7 commits April 8, 2026 17:43
Co-authored-by: Matthias RAIGNE <5262628+Matt75@users.noreply.github.com>
Co-authored-by: Matthias RAIGNE <5262628+Matt75@users.noreply.github.com>
Co-authored-by: Matthias RAIGNE <5262628+Matt75@users.noreply.github.com>
@L3RAZ L3RAZ force-pushed the feat/PAYSHIP-3949 branch from ed6dfb9 to 00537ee Compare April 8, 2026 14:53
@matks matks added this to the 5.3.1 milestone Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants