fixed: OnRegister clears baseDevice when physical address already resolved#706
Open
jwmay2012 wants to merge 1 commit intoPulse-Eight:masterfrom
Open
fixed: OnRegister clears baseDevice when physical address already resolved#706jwmay2012 wants to merge 1 commit intoPulse-Eight:masterfrom
jwmay2012 wants to merge 1 commit intoPulse-Eight:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During
RegisterClient,SetConfigurationcallsSetHDMIPort(baseDevice, port)which resolves the physical address and storesbaseDevice(e.g.CECDEVICE_AUDIOSYSTEM). ThenOnRegistercallsSetPhysicalAddress(m_configuration)again, but sinceiPhysicalAddressis already valid from the earlier resolution, it takes the "provided physical address" path which zeroes outbaseDeviceandiHDMIPort:https://github.com/Pulse-Eight/libcec/blob/libcec-7.1.1/src/libcec/CECClient.cpp#L229-L240
After
OnRegisterreturns,m_configuration.baseDeviceisCECDEVICE_UNKNOWN. Kodi reads this back viaGetCurrentConfigurationright afterOpen()completes, interprets it as "connected to TV", and persists that to its settings. Next boot, Kodi passesCECDEVICE_TVinstead ofCECDEVICE_AUDIOSYSTEMtoSetHDMIPort, gets the wrong physical address, and CEC stops working.The fix skips the
SetPhysicalAddresscall inOnRegisterwhen the address is already resolved. No change toSetPhysicalAddressitself.Tested on LibreELEC 12.2.1 with Pulse-Eight USB adapter behind a Yamaha AVR,
baseDevicestays correct across reboots.Related: https://forum.libreelec.tv/thread/30065-x86-64-cec-broke-after-updating-to-le-12-2-0/, #679, #687, #698, #699