refactor: simplify handling of imports deferred to a continuation line - #365
Merged
Conversation
Follow-up to #354. Instead of threading a give-up flag through FilterMultilineImport.__init__ and __call__, skip constructing the filter entirely when the first line has no `import` keyword: the statement can never be filtered, and the class never accumulated any continuation lines in that case anyway (with empty `imports` the pending fix was immediately over). Behavior is unchanged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #354.
Instead of threading a give-up flag through
FilterMultilineImport.__init__and__call__, skip constructing the filter entirely when the first line has noimportkeyword: the statement can never be filtered, and the class never accumulated any continuation lines in that case anyway — with emptyimportsthe pending fix was immediately over, so the extra__call__branch always returned the first line verbatim.This restores
FilterMultilineImportto its pre-#354 shape and moves the guard tofilter_unused_import(+5/−19).Testing
importis on the second line #354.importis on the second line #354 across the issue reproducer and variants (unused/all-unused names, parens on the continuation line, double continuation, indented block).🤖 Generated with Claude Code