-
Notifications
You must be signed in to change notification settings - Fork 141
Encapsulate pipette batch scheduling into backend-agnostic module #949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BioCam
wants to merge
19
commits into
PyLabRobot:main
Choose a base branch
from
BioCam:encapsulate-pipette-batch-scheduling
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
d8babe3
Encapsulate pipette batch scheduling into dedicated module
BioCam 8eece6f
make x_grouping_tolerance required argument
BioCam cbee224
Merge branch 'PyLabRobot:main' into encapsulate-pipette-batch-scheduling
BioCam fa39d12
Merge branch 'PyLabRobot:main' into encapsulate-pipette-batch-scheduling
BioCam a032cd5
Fix spacings list sizing in plan_batches when num_channels exceeds ma…
BioCam 4310973
Remove detection parameter exposure from probe_liquid_heights (defer …
BioCam 607565b
explain dual exception handling
BioCam ae9cc13
Merge branch 'main' into encapsulate-pipette-batch-scheduling
BioCam b3b326b
Merge branch 'PyLabRobot:main' into encapsulate-pipette-batch-scheduling
BioCam 6d53765
Refactor plan_batches to accept containers, add execute_batched, fix …
BioCam 564f36a
create `print_batches`
BioCam f6e8690
fix linting
BioCam 9c3448a
`make format`
BioCam 8c3b851
Merge branch 'main' into encapsulate-pipette-batch-scheduling
rickwierenga 5bf7bb6
Merge branch 'main' into encapsulate-pipette-batch-scheduling
BioCam 5147f11
update docstrings
BioCam 5e46375
Merge branch 'main' into encapsulate-pipette-batch-scheduling
BioCam d143bdf
Merge branch 'main' into encapsulate-pipette-batch-scheduling
BioCam c7e18ff
Merge branch 'main' into encapsulate-pipette-batch-scheduling
BioCam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
535 changes: 211 additions & 324 deletions
535
pylabrobot/liquid_handling/backends/hamilton/STAR_backend.py
Large diffs are not rendered by default.
Oops, something went wrong.
BioCam marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with the removal of
execute_batched, the code becomes a lot less modular. and we do want to useexecute_batchedfor other commands in the futureThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting, the current
execute_batchedseemed very limited to probing actions, which is why I removed it, but you're saying that it actually acts as an abstraction layer for any function that is meant to be called after the channels have moved to their target locations - I really like thisI will work on an implementation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I returned it and tried to make it even more adaptive:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with small adjustment to this workflow we can use it for...