Expose STARBackend.move_channel_probe_z()#961
Open
BioCam wants to merge 6 commits intoPyLabRobot:mainfrom
Open
Expose STARBackend.move_channel_probe_z()#961BioCam wants to merge 6 commits intoPyLabRobot:mainfrom
STARBackend.move_channel_probe_z()#961BioCam wants to merge 6 commits intoPyLabRobot:mainfrom
Conversation
Bypasses the C0 master module (KZ) by sending ZA directly to the pip channel, enabling Z moves with configurable speed/acceleration even when the firmware's tip-picked-up flag is incorrectly set. Also updates `move_channel_z` docstring.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR exposes a new low-level per-channel Z movement API on the Hamilton STAR backend, intended to bypass master-module routed Z moves when the instrument’s internal “tip picked up” state causes incorrect behavior.
Changes:
- Clarifies
move_channel_zsemantics in its docstring (tip-dependent reference point). - Adds
STARBackend.move_channel_probe_z()to move an individual channel’s probe Z-drive directly via the channel module.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Collaborator
Author
|
@rickwierenga, @ben-ray, @cmoscy, @jrast Should we call this 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.