stop inlining config into pyo3-build-config; generate directly in pyo3-ffi#5862
Draft
davidhewitt wants to merge 7 commits intoPyO3:mainfrom
Draft
stop inlining config into pyo3-build-config; generate directly in pyo3-ffi#5862davidhewitt wants to merge 7 commits intoPyO3:mainfrom
pyo3-build-config; generate directly in pyo3-ffi#5862davidhewitt wants to merge 7 commits intoPyO3:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an experiment to simplify
pyo3-build-configto not have abuild.rsitself, and letpyo3-build-configdo the hard work. Instead, callers ofpyo3-build-configAPIs must themselves have a direct dependency onpyo3orpyo3-ffito pull information via env vars propagated by cargo.I suspect that this will make integration of pyo3 with e.g.
meson-pythonsignificantly easier, see e.g. mesonbuild/meson-python#721 (comment)I also hope that it will enable faster CI;
pyo3-build-configitself should now never need to rebuild when switching between abi3 / non-abi3.