Add ownership-moving variants of readonly and readwrite
#524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The additional `PyArray` methods `try_into_readonly` and `try_into_readwrite` allow directly moving the ownership of the `Bound` pointer backing a `PyArray` into the relevant view type. This both a) avoids reference counting overhead and b) allows methods on `PyReadwriteArray` (like `resize`) that _require_ unique pointer referencing, not just unique active borrows to function without the user having to manually drop the base guard.
Icxolu
reviewed
Jan 7, 2026
Contributor
Icxolu
left a comment
Icxolu
left a comment
There was a problem hiding this comment.
Adding these is reasonable I think. Left a couple of small comments. Adding a changelog entry would be great.
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The additional
PyArraymethodstry_into_readonlyandtry_into_readwriteallow directly moving the ownership of theBoundpointer backing aPyArrayinto the relevant view type. This both a) avoids reference counting overhead and b) allows methods onPyReadwriteArray(likeresize) that require unique pointer referencing, not just unique active borrows to function without the user having to manually drop the base guard.Fix #522