Stream Ray job logs with rolling buffer to bound memory usage#2101
Draft
avilches wants to merge 3 commits into
Draft
Stream Ray job logs with rolling buffer to bound memory usage#2101avilches wants to merge 3 commits into
avilches wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a Ray job produces very large logs (e.g. 1 GB),
RayRunner.logs()was callingJobSubmissionClient.get_job_logs(), which downloads the entire log into a Python string beforecheck_logs()can truncate it to the 50 MB limit. This causes OOM errors or HTTP timeouts.Solution
Replace the blocking
get_job_logs()call with a direct streaming HTTP GET to the Ray dashboard endpoint ({host}api/jobs/{job_id}/logs). Logs are read in 64 KB chunks into acollections.dequerolling buffer that discards the oldest chunks once the accumulated size exceedsFUNCTIONS_LOGS_SIZE_LIMIT.Result: memory usage is bounded to ~50 MB regardless of total log size. The same amount of data travels over the network, but it is never all resident in RAM at once.
Behaviour preserved
check_logstruncation)check_logs()call sites are untouched and continue to handle theFAILED + empty logscase and act as a safety net for other runners