Distinguish section mutations from item mutations#16
Open
ivopintodasilva wants to merge 3 commits intoRACCommunity:masterfrom
Open
Distinguish section mutations from item mutations#16ivopintodasilva wants to merge 3 commits intoRACCommunity:masterfrom
ivopintodasilva wants to merge 3 commits intoRACCommunity:masterfrom
Conversation
Member
|
will need to be released as a major version |
Member
|
FlexibleDiff/FlexibleDiff/SectionedChangeset.swift Lines 31 to 33 in fe1cd9f The precondition here is no longer valid, so it will need to be updated. Since this has to be released as a API breaking change, I wonder if it is worth dropping |
6028923 to
785aab0
Compare
|
Bumping this 😇 @andersio are you still waiting for changes, or can this work get merged and a new release cut? Thanks! 🙏🏼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello 👋
On the original implementation of FlexibleDiff we are considering a section mutation happens when:
I've forked the library and have been using a slightly different approach where the
Changesetonly reveals a section mutation when the actual section's metadata has changed, disregarding any changes on the section's items for this purpose.In my use case, this gives me a direct correlation between the changeset and the updates that I need to perform on a given collection view:
What do you think about this approach?
Thanks for the great work! 😃