Skip to content

[ROCM-28989] Fix msgpack symbol conflict - #5118

Open
shivadbhavsar wants to merge 7 commits into
developfrom
msgpack_visibility
Open

[ROCM-28989] Fix msgpack symbol conflict#5118
shivadbhavsar wants to merge 7 commits into
developfrom
msgpack_visibility

Conversation

@shivadbhavsar

Copy link
Copy Markdown
Contributor

Motivation

See #4366

Technical Details

Change visibility settings on exported headers

Changelog Category

Add a CHANGELOG.md entry for any option other than Not Applicable

    • Added: New functionality.
    • Changed: Changes to existing functionality.
    • Removed: Functionality or support that has been removed. (Compared to a previous release)
    • Optimized: Component performance that has been optimized or improved.
    • Resolved Issues: Known issues from a previous version that have been resolved.
    • Not Applicable: This PR is not to be included in the changelog.

Follow the LLVM AI Tool Use Policy for contributions using AI.

@shivadbhavsar shivadbhavsar self-assigned this Aug 6, 2026
@shivadbhavsar
shivadbhavsar requested a review from causten as a code owner August 6, 2026 16:51
@shivadbhavsar
shivadbhavsar requested review from TedThemistokleous and pfultz2 and a lite review from Copilot August 6, 2026 16:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@TedThemistokleous TedThemistokleous added high priority A PR with high priority for review and merging. simple small or simple changes Windows Related changes for Windows Environments bugfix Fixes a bug found in the code. and removed Windows Related changes for Windows Environments labels Aug 6, 2026
@causten
causten requested a balanced review from Copilot August 6, 2026 17:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@gh-app-migraphx-bot-pr-write

Copy link
Copy Markdown
Test Batch New Rate (8111fd) Old Rate (3a503c)* Diff Status
torchvision-resnet50 64 614.78 3,264.92 -81.17% 🔴
torchvision-resnet50_fp16 64 6,840.60 7,548.67 -9.38% 🔴
torchvision-densenet121 32 1,146.70 2,483.99 -53.84% 🔴
torchvision-densenet121_fp16 32 5,023.67 5,004.24 0.39%
torchvision-inceptionv3 32 769.42 2,058.51 -62.62% 🔴
torchvision-inceptionv3_fp16 32 4,193.89 4,416.99 -5.05% 🔴
cadene-inceptionv4 16 71.27 820.61 -91.31% 🔴
cadene-resnext64x4 16 305.33 782.78 -60.99% 🔴
slim-mobilenet 64 5,732.10 8,386.36 -31.65% 🔴
slim-nasnetalarge 64 177.29 228.86 -22.53% 🔴
slim-resnet50v2 64 1,160.93 3,180.91 -63.50% 🔴
bert-mrpc-onnx 8 428.47 1,168.84 -63.34% 🔴
bert-mrpc-tf 1 400.35 498.63 -19.71% 🔴
pytorch-examples-wlang-gru 1 470.23 473.35 -0.66%
pytorch-examples-wlang-lstm 1 166.44 384.83 -56.75% 🔴
torchvision-resnet50_1 1 76.79 1,046.63 -92.66% 🔴
cadene-dpn92_1 1 35.32 437.32 -91.92% 🔴
cadene-resnext101_1 1 96.90 365.89 -73.52% 🔴
onnx-taau-downsample 1 339.48 844.09 -59.78% 🔴
dlrm-criteoterabyte 1 20.54 32.42 -36.65% 🔴
dlrm-criteoterabyte_fp16 1 48.53 51.80 -6.32% 🔴
agentmodel 1 10,079.23 9,209.12 9.45% 🔆
unet_fp16 2 53.32 58.80 -9.32% 🔴
resnet50v1_fp16 1 1,488.07 1,366.11 8.93% 🔆
resnet50v1_int8 1 561.73 1,883.96 -70.18% 🔴
bert_base_cased_fp16 64 792.37 1,098.16 -27.85% 🔴
bert_large_uncased_fp16 32 345.75 345.59 0.05%
bert_large_fp16 1 96.30 206.59 -53.39% 🔴
distilgpt2_fp16 16 2,085.04 2,092.89 -0.38%
yolov5s 1 217.20 558.33 -61.10% 🔴
tinyllama 1 26.63 45.83 -41.90% 🔴
vicuna-fastchat 1 27.80 44.20 -37.10% 🔴
whisper-tiny-encoder 1 210.88 411.87 -48.80% 🔴
whisper-tiny-decoder 1 408.98 408.48 0.12%
llama2_7b 1 5.51 20.84 -73.56% 🔴
qwen1.5-7b 1 23.59 23.58 0.04%
phi3-3.8b 1 26.81 26.72 0.34%
llama3-8b 1 21.73 21.80 -0.32%
whisper-large-encoder 1 10.13 10.18 -0.43%
whisper-large-decoder 1 105.93 105.30 0.60%
mistral-7b 1 23.78 23.78 0.02%
FLUX.1-schnell 1 776.76 755.22 2.85%

Regressions detected 🔴

* No develop baseline was found for this PR's branch point; compared against the latest available develop run instead.

@gh-app-migraphx-bot-pr-write

Copy link
Copy Markdown
Test Status Result
bert-mrpc-onnx PASSED: MIGraphX meets tolerance
bert-mrpc-tf PASSED: MIGraphX meets tolerance
pytorch-examples-wlang-gru PASSED: MIGraphX meets tolerance
pytorch-examples-wlang-lstm PASSED: MIGraphX meets tolerance
dlrm-criteoterabyte PASSED: MIGraphX meets tolerance
agentmodel PASSED: MIGraphX meets tolerance
unet PASSED: MIGraphX meets tolerance
resnet50v1 PASSED: MIGraphX meets tolerance
bert_base_cased_fp16 PASSED: MIGraphX meets tolerance
bert_large_uncased_fp16 🔴 FAILED: MIGraphX is not within tolerance - check verbose output
bert_large PASSED: MIGraphX meets tolerance
yolov5s PASSED: MIGraphX meets tolerance
tinyllama PASSED: MIGraphX meets tolerance
vicuna-fastchat PASSED: MIGraphX meets tolerance
whisper-tiny-encoder PASSED: MIGraphX meets tolerance
whisper-tiny-decoder PASSED: MIGraphX meets tolerance
distilgpt2_fp16 PASSED: MIGraphX meets tolerance
llama2_7b PASSED: MIGraphX meets tolerance
qwen1.5-7b PASSED: MIGraphX meets tolerance
phi3-3.8b PASSED: MIGraphX meets tolerance
llama3-8b PASSED: MIGraphX meets tolerance
whisper-large-encoder 🔴 FAILED: MIGraphX is not within tolerance - check verbose output
whisper-large-decoder PASSED: MIGraphX meets tolerance
mistral-7b PASSED: MIGraphX meets tolerance
FLUX.1-schnell PASSED: MIGraphX meets tolerance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fixes a bug found in the code. high priority A PR with high priority for review and merging. simple small or simple changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants