[AIMIGRAPHX-1229] Support ROCm10 TheRock packaging with alternative GPU dependencies - #5120
Open
kentqian wants to merge 1 commit into
Open
[AIMIGRAPHX-1229] Support ROCm10 TheRock packaging with alternative GPU dependencies#5120kentqian wants to merge 1 commit into
kentqian wants to merge 1 commit into
Conversation
…se package alternatives for rocm10
Regressions detected 🔴 * No develop baseline was found for this PR's branch point; compared against the latest available develop run instead. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
After reviewing the ROCm 7.13 packaging work in
bumpci7_13and comparing it with the ROCm 10 multi-arch package layout, we need a dependency model that supports both repository formats.ROCm 7.13/7.14 repositories use GPU-family-suffixed packages, while ROCm 10 multi-arch repositories provide raw GPU-target packages together with architecture-neutral meta packages.
Generating one MIGraphX package per GPU architecture would duplicate the same MIGraphX files and introduce package conflicts. Weak dependencies such as
RecommendsorSuggestsalso do not guarantee that the required GPU library is installed.This PR keeps one fat MIGraphX package set per build and expresses the GPU library requirement as a hard alternative dependency. An already installed device package satisfies the dependency, while the meta package remains a safe fallback.
Technical Details
GPU_TARGETS, removing feature suffixes and duplicates.MIGRAPHX_THEROCK_GPU_ARCHas an override for legacy GPU-family package names.meta | arch1 | arch2(arch1 or arch2 or meta)Changelog Category
Add a
CHANGELOG.mdentry for any option other thanNot ApplicableFollow the LLVM AI Tool Use Policy for contributions using AI.