[Enhancement] aglin online quantizaiton and offline quantization#1365
Open
haoyangli0109 wants to merge 1 commit into
Open
[Enhancement] aglin online quantizaiton and offline quantization#1365haoyangli0109 wants to merge 1 commit into
haoyangli0109 wants to merge 1 commit into
Conversation
Signed-off-by: Haoyang Li <lihaoyang0109@gmail.com>
050f816 to
f2f8d07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main difference in precision stems from the different
round_modesettings used during scale calculations. Previously, we used Aiter’smxfp4kernel for online quantization, which usesround_up, whereas the offline Quark kernel usesround_even. In terms of precision,round_evenis more advantageous.This PR fixes this issue, and switching the kernel does not result in any additional overhead for online quantization.
Please note that you need to use gsm8kshot3 to reproduce the issue; gsm8kshot5 has nearly identical accuracy.
before
modified: