Add PA_PS 8-wave kernel for MI308 with co-execution#2630
Open
quintinwang5 wants to merge 2 commits intomainfrom
Open
Add PA_PS 8-wave kernel for MI308 with co-execution#2630quintinwang5 wants to merge 2 commits intomainfrom
quintinwang5 wants to merge 2 commits intomainfrom
Conversation
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Performance optimization for PA_PS on MI308 with co-execution enabled. To use this feature, just add
--wave_per_tg 8python op_tests/test_pa_ps.py -b 80 -n 10,1 -q 4 --block_size 1024 --quant_type per_1024x128 --wave_per_tg 8Technical Details
Original 4-wave implements cannot benefit from MFMA co-execution .
The default option is
wave_per_tg=4(same as before).Test Plan
Test Result
Submission Checklist