Conversation
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
|
Contributor
|
@HaonanWang98 Have all these configs been tuned on gfx1250? |
azaidy
requested changes
Apr 8, 2026
Contributor
azaidy
left a comment
azaidy
left a comment
There was a problem hiding this comment.
If configs have not been tuned on gfx1250 please only create a fallback config per triton kernel. Do not create dedicated NK configs unless they are guaranteed to be best performing
HaonanWang98
force-pushed
the
455_test
branch
2 times, most recently
from
385ed1d to
e8bacb0
Compare
valarLip
reviewed
Apr 15, 2026
| if hip_version > Version("6.2.41133"): | ||
| flags_hip += ["-mllvm -amdgpu-coerce-illegal-types=1"] | ||
| if get_gfx() == "gfx950" and int(os.getenv("AITER_FP4x2", "1")) > 0: | ||
| if (get_gfx() == "gfx950" or get_gfx() == "gfx1250") and int( |
| q, k, v = [maybe_contiguous(x) for x in (q, k, v)] | ||
|
|
||
| if can_impl_fmha_v3_fwd(): | ||
| can_impl_fmha_v3_fwd_triton = ( |
| ) | ||
|
|
||
|
|
||
| def flash_attn_varlen_func( |
valarLip
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist