Skip to content

AORTA-23 : Phase 4 : Generate excel report for baseline vs test configuration#101

Open
prosenjitdhole wants to merge 8 commits into
prosenj_cli_hq_eval_report_phase_3from
prosenj_cli_hq_eval_report_phase_4
Open

AORTA-23 : Phase 4 : Generate excel report for baseline vs test configuration#101
prosenjitdhole wants to merge 8 commits into
prosenj_cli_hq_eval_report_phase_3from
prosenj_cli_hq_eval_report_phase_4

Conversation

@prosenjitdhole

Copy link
Copy Markdown
Collaborator

No description provided.

@prosenjitdhole prosenjitdhole changed the title [WIP] AORTA-23 : Phase 4 : Generate excel report for baseline vs test configuration AORTA-23 : Phase 4 : Generate excel report for baseline vs test configuration Feb 18, 2026
@prosenjitdhole prosenjitdhole marked this pull request as ready for review February 18, 2026 09:32
@prosenjitdhole prosenjitdhole requested a review from Copilot March 4, 2026 16:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Phase 4 support for generating an Excel report that compares baseline vs test HW queue sweep results across multiple workloads (Mode C), integrating it into the existing reporting pipeline.

Changes:

  • Wire comparison-mode pipeline step to generate a multi-workload comparison Excel workbook.
  • Implement Mode C Excel generation: summary, by-stream throughput/latency, regressions/improvements, missing workloads, and environment sheets + conditional formatting.
  • Export generate_comparison_excel via the generators package.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File Description
src/aorta/report/pipelines/hwqueue_pipeline.py Calls the new comparison Excel generator during Mode C execution and records generated outputs + regression/improvement lists.
src/aorta/report/generators/hwqueue_excel.py Implements generate_comparison_excel and helpers to build/format the comparison workbook.
src/aorta/report/generators/__init__.py Re-exports generate_comparison_excel.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/aorta/report/generators/hwqueue_excel.py
Comment thread src/aorta/report/generators/hwqueue_excel.py Outdated
Comment thread src/aorta/report/generators/hwqueue_excel.py Outdated
Comment thread src/aorta/report/generators/hwqueue_excel.py Outdated
Comment thread src/aorta/report/generators/hwqueue_excel.py
Comment thread src/aorta/report/generators/hwqueue_excel.py
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 6, 2026 12:01
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

@prosenjitdhole I've opened a new pull request, #131, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

@prosenjitdhole I've opened a new pull request, #132, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/aorta/report/generators/hwqueue_excel.py
Comment thread src/aorta/report/generators/hwqueue_excel.py Outdated
Comment thread src/aorta/report/generators/hwqueue_excel.py Outdated
Comment thread src/aorta/report/generators/hwqueue_excel.py

Copilot AI commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

@prosenjitdhole I've opened a new pull request, #133, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

@prosenjitdhole I've opened a new pull request, #134, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 6, 2026 12:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/aorta/report/generators/hwqueue_excel.py
Comment thread src/aorta/report/generators/hwqueue_excel.py Outdated
Comment thread src/aorta/report/generators/hwqueue_excel.py
Comment thread src/aorta/report/generators/hwqueue_excel.py Outdated
Copilot AI and others added 2 commits March 6, 2026 19:07
…parison sheet (#133)

* Initial plan

* Add TODO noting baseline and test labels are assumed to be distinct

Co-authored-by: prosenjitdhole <239307697+prosenjitdhole@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: prosenjitdhole <239307697+prosenjitdhole@users.noreply.github.com>
* Initial plan

* Fix zero-value handling: use `is not None` instead of truthiness checks

Co-authored-by: prosenjitdhole <239307697+prosenjitdhole@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: prosenjitdhole <239307697+prosenjitdhole@users.noreply.github.com>
Co-authored-by: prosenjitdhole <prosenjit.dhole@amd.com>
Copilot AI review requested due to automatic review settings March 6, 2026 13:43
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

* Initial plan

* Add TODO comments for is not None checks in _build_throughput_by_streams_sheet

Co-authored-by: prosenjitdhole <239307697+prosenjitdhole@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: prosenjitdhole <239307697+prosenjitdhole@users.noreply.github.com>
Co-authored-by: prosenjitdhole <prosenjit.dhole@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants