Add TODO for duplicate find_common_workloads() call in hwqueue pipeline#126
Merged
prosenjitdhole merged 2 commits intoMar 6, 2026
Merged
Conversation
Co-authored-by: prosenjitdhole <239307697+prosenjitdhole@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add optimization TODO in pipeline command
Add TODO for duplicate find_common_workloads() call in hwqueue pipeline
Mar 6, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Documents a known performance inefficiency in the HWQueue comparison pipeline where workload discovery is performed twice, helping future maintainers avoid redundant directory scanning at scale.
Changes:
- Added a TODO comment at the
HWQueueLoader.load_comparison_data()call site noting the duplicatefind_common_workloads()scan. - Suggested two concrete follow-up remediation paths (use
load_comparison_data()as the single source of truth, or pass/derive from already-computed workload sets).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
find_common_workloads()is called explicitly in the pipeline, then called again internally byload_comparison_data(), duplicating directory scanning work — noticeable at scale.Changes
TODOcomment at theload_comparison_data()call site inhwqueue_pipeline.pydocumenting the redundant scan and suggesting two remediation paths:load_comparison_data()and extractcommon/baseline_only/test_onlyfrom its return valuecommonlist to avoid re-scanning✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.