adds docker for therock with asan enabled by amd-vivekag · Pull Request #144 · ROCm/aorta

amd-vivekag · 2026-03-20T15:21:30Z

adds docker for therock with asan enabled

…ired for hipruntime

Copilot

Pull request overview

Adds a new Docker image variant intended for debugging host-side HIP/ROCm issues with AddressSanitizer enabled via TheRock, and exposes it through the existing Docker env selection flow.

Changes:

Adds Dockerfile.therock-host-asan-pytorch to build TheRock with HOST_ASAN and then build PyTorch against that stack.
Extends docker/setup-env.sh to allow selecting the new Dockerfile (choice 5).
Documents the new Dockerfile option in docker/.env.example.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
docker/setup-env.sh	Adds interactive selection entry for the new TheRock HOST_ASAN + PyTorch Dockerfile.
docker/Dockerfile.therock-host-asan-pytorch	New Dockerfile that builds TheRock with HOST_ASAN and builds PyTorch from source against it.
docker/.env.example	Adds the new Dockerfile option and brief description to the env template.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-20T15:27:58Z

+RUN git clone --branch ${THEROCK_GIT_REF} --single-branch \
+    https://github.com/ROCm/TheRock.git


git clone --branch ${THEROCK_GIT_REF} only supports branches/tags. If you want to support commit SHAs for reproducible builds, clone without --branch (or fetch) and git checkout the SHA explicitly.

Suggested change

RUN git clone --branch ${THEROCK_GIT_REF} --single-branch \

https://github.com/ROCm/TheRock.git

RUN git clone https://github.com/ROCm/TheRock.git && \

cd TheRock && \

git checkout ${THEROCK_GIT_REF}

Thanks for flagging this. I am keeping git clone --branch ${THEROCK_GIT_REF} --single-branch --depth 1 as-is: THEROCK_GIT_REF is documented (and enforced in THEROCK_ASAN_BUILD_ISSUES.md) to be a release tag that must match THEROCK_TARBALL_VERSION for ABI compatibility, so an arbitrary commit SHA is intentionally out of scope, and the shallow single-branch clone is a deliberate build-time optimization a SHA checkout would lose. Happy to revisit if we ever need SHA-pinned ASAN builds.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 12 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…g docker images

…eed_gpu, doc+README fixes (#144) Co-authored-by: Cursor <cursoragent@cursor.com>

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 5 comments.

…RARY_PATH under set -u, use overlay-dir var in messages, readelf over ldd, non-empty BASE_IMAGE default (#144) Co-authored-by: Cursor <cursoragent@cursor.com>

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 5 comments.

amd-vivekag · 2026-06-19T16:55:09Z

+RUN apt-get update && apt-get install -y \
+    build-essential \
+    gfortran \
+    git \
+    ninja-build \


Thanks for flagging this. I am keeping it as-is: the cmake --preset invocation runs inside . .venv/bin/activate (line 219), and cmake is provided by TheRock requirements.txt installed into that venv at line 197 (pip install -r requirements.txt), so a system cmake is not needed for the TheRock ASAN build. The Kitware system cmake added later (line 314) is only for the separate PyTorch build stage, which is why the initial apt layer intentionally omits cmake. Happy to add a one-line comment there if it helps future readers.

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.

…ays PASSED (#144) Co-authored-by: Cursor <cursoragent@cursor.com>

…_DIR in verify_asan_therock (#144) Co-authored-by: Cursor <cursoragent@cursor.com>

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.

+RUN cmake --install build-asan --prefix /tmp/rocm-asan-full && \
+    mkdir -p /opt/rocm-asan/lib && \
+    for lib in libamdhip64 libhsa-runtime64 libhsakmt libamd_comgr; do \
+        find /tmp/rocm-asan-full/lib -name "${lib}.so*" -exec cp -a {} /opt/rocm-asan/lib/ \; ; \
+    done && \
+    rm -rf /tmp/rocm-asan-full


+NORMAL_HIP="$ROCM/lib/libamdhip64.so"
+if [ -f "$NORMAL_HIP" ]; then
+    if nm -D "$NORMAL_HIP" 2>/dev/null | grep -q '__asan_'; then
+        check "Normal libamdhip64.so is NOT ASAN-instrumented" "fail"
+    else
+        check "Normal libamdhip64.so is NOT ASAN-instrumented" "pass"
+    fi
+fi


Copilot AI review requested due to automatic review settings March 20, 2026 15:21

adds docker for therock with asan enabled

35b0771

amd-vivekag force-pushed the users/vivekag/therock_asan_docker branch from a47d7c0 to 35b0771 Compare March 20, 2026 15:21

fixes build issues by disabling ASAN for libraries which are not requ…

ee63cd1

…ired for hipruntime

Copilot started reviewing on behalf of amd-vivekag March 20, 2026 15:23 View session

Copilot AI reviewed Mar 20, 2026

View reviewed changes

amd-vivekag added 2 commits March 24, 2026 14:30

fixes pytorch nccl build and adds a doc for build issues

6d313b3

fixes some of the RCCL header file installation issues for pytorch build

285fd1b

Copilot AI review requested due to automatic review settings March 24, 2026 17:49

Copilot started reviewing on behalf of amd-vivekag March 24, 2026 17:51 View session

Copilot AI reviewed Mar 24, 2026

View reviewed changes

Comment thread docker/Dockerfile.therock-host-asan-pytorch Outdated

Comment thread docker/Dockerfile.therock-host-asan-pytorch Outdated

Comment thread docker/Dockerfile.therock-host-asan-pytorch Outdated

amd-vivekag added 2 commits March 25, 2026 10:11

docker in building state

51a6f72

adds tests which verifies TheRock with ASAN docker build setup in docker

7f4e9fd

Copilot AI review requested due to automatic review settings March 25, 2026 13:37

Copilot started reviewing on behalf of amd-vivekag March 25, 2026 13:39 View session

Copilot AI reviewed Mar 25, 2026

View reviewed changes

amd-vivekag added 2 commits March 31, 2026 10:28

fixes long time build issues with asan library

29d4197

reduces docker built time from 4-6 hours to 30-40 min

c9ea625

Copilot AI review requested due to automatic review settings March 31, 2026 16:32

Copilot started reviewing on behalf of amd-vivekag March 31, 2026 16:33 View session

Copilot AI reviewed Mar 31, 2026

View reviewed changes

amd-vivekag and others added 2 commits April 1, 2026 15:17

adds new dockerfile to overlay asan for hip_runtime on top of existin…

fbdf647

…g docker images

address review: real exit codes in verify_asan_therock, drop unused n…

218643b

…eed_gpu, doc+README fixes (#144) Co-authored-by: Cursor <cursoragent@cursor.com>

Copilot AI review requested due to automatic review settings June 19, 2026 16:39

Copilot started reviewing on behalf of amd-vivekag June 19, 2026 16:40 View session

Copilot AI reviewed Jun 19, 2026

View reviewed changes

Comment thread tests/asan_tests/verify_asan_pytorch.sh

Comment thread tests/asan_tests/verify_asan_active.sh

Comment thread tests/asan_tests/verify_asan_active.sh

Comment thread docker/docker-compose.build.yaml

Comment thread tests/asan_tests/test_therock_asan.py

amd-vivekag requested a review from Copilot June 19, 2026 16:43

Copilot started reviewing on behalf of amd-vivekag June 19, 2026 16:44 View session

address review r2: drop errexit-enabling set -e toggles, guard LD_LIB…

58a805f

…RARY_PATH under set -u, use overlay-dir var in messages, readelf over ldd, non-empty BASE_IMAGE default (#144) Co-authored-by: Cursor <cursoragent@cursor.com>

Copilot AI reviewed Jun 19, 2026

View reviewed changes

amd-vivekag requested a review from Copilot June 19, 2026 16:50

Copilot started reviewing on behalf of amd-vivekag June 19, 2026 16:50 View session

Copilot AI reviewed Jun 19, 2026

View reviewed changes

Comment thread tests/asan_tests/verify_asan_active.sh Outdated

Comment thread tests/asan_tests/verify_asan_therock.sh

amd-vivekag and others added 2 commits June 19, 2026 16:54

address review r3: test_clean prints PASSED/FAILED by errors, not alw…

45c8ba4

…ays PASSED (#144) Co-authored-by: Cursor <cursoragent@cursor.com>

address review r4: quote $TMPDIR in cleanup trap, drop unused ASAN_RT…

9a831e5

…_DIR in verify_asan_therock (#144) Co-authored-by: Cursor <cursoragent@cursor.com>

Copilot AI review requested due to automatic review settings June 19, 2026 16:57

Copilot started reviewing on behalf of amd-vivekag June 19, 2026 16:58 View session

Copilot AI reviewed Jun 19, 2026

View reviewed changes

		RUN git clone --branch ${THEROCK_GIT_REF} --single-branch \
		https://github.com/ROCm/TheRock.git

-RUN git clone --branch ${THEROCK_GIT_REF} --single-branch \
-    https://github.com/ROCm/TheRock.git
+RUN git clone https://github.com/ROCm/TheRock.git && \
+    cd TheRock && \
+    git checkout ${THEROCK_GIT_REF}

Uh oh!

Conversation

amd-vivekag commented Mar 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

amd-vivekag Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

amd-vivekag Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers