[ROCM-27193] Add gfx1250 to MIOpen CK supported archs and known arch list#8875
Merged
BradPepersAMD merged 4 commits intoJul 2, 2026
Merged
Conversation
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
JonathanLichtnerAMD
approved these changes
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ID : ROCM-27193
Motivation
gfx1250 is a new AMD GPU architecture that was missing from MIOpen's Composable Kernel (CK) supported architecture list and from the known-architecture enumeration used in handle unit tests. Without this entry, any MIOpen build targeting gfx1250 silently skips all CK grouped-conv solvers, and the
handle_testsuite would fail or produce a false negative on gfx1250 hardware.Technical Details
Two additive, one-line changes following the same pattern used for prior gfx generations:
projects/miopen/src/ck_impl/CMakeLists.txt— Addedgfx1250to_CK_SUPPORTED_ARCHS. This list gates which GPU targets receive CK grouped-conv kernel compilation within MIOpen's CMake build. Missing entries cause the target to be silently filtered out of the grouped-conv solver set.projects/miopen/test/gtest/handle_test.cpp— Added"gfx1250"to the static expected-architecture array intest_arch_name(). This test validates thatMIOpen::Handle::GetDeviceName()returns a string from the known-good set; omitting gfx1250 would cause a test failure on gfx1250 hardware.No logic changes, no API surface modifications, and no existing architectures are affected.
Risk Assessment
Risk Level: 🟢 Low
Impacted Components
projects/miopen/src/ck_impl/CMakeLists.txt— CK grouped-conv solver build configurationprojects/miopen/test/gtest/handle_test.cpp— Handle/arch-name unit testPotential Side Effects
Mitigation Steps
handle_testand any gfx1250-targeted build jobs, catching regressions immediately.Test Plan
Run the failing smoke tests and confirm that they are not failing with the following errors anymore:
Missing arch in gtest
Test Result
unknown_gpuexceptionReduce accuracy mismatch - Fixed with [ROCM-26590] Fix legacy-CK buffer resource descriptor for gfx1250 #8758
GPU_Reduce_FP32 (432 tests) and GPU_Reduce_FP16RNN Vanilla backward weights failure - Fixed with [ROCM-26590] Fix legacy-CK buffer resource descriptor for gfx1250 #8758
GPU_RNNVanilla_FP32 and GPU_RNNVanillaDropout_FP32Submission Checklist