Skip to content

[ROCM-27193] Add gfx1250 to MIOpen CK supported archs and known arch list#8875

Merged
BradPepersAMD merged 4 commits into
developfrom
users/SreecharanGundaboluAMD/fix_gfx1250_smake_tests
Jul 2, 2026
Merged

[ROCM-27193] Add gfx1250 to MIOpen CK supported archs and known arch list#8875
BradPepersAMD merged 4 commits into
developfrom
users/SreecharanGundaboluAMD/fix_gfx1250_smake_tests

Conversation

@SreecharanGundaboluAMD

@SreecharanGundaboluAMD SreecharanGundaboluAMD commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

JIRA ID : ROCM-27193

Motivation

gfx1250 is a new AMD GPU architecture that was missing from MIOpen's Composable Kernel (CK) supported architecture list and from the known-architecture enumeration used in handle unit tests. Without this entry, any MIOpen build targeting gfx1250 silently skips all CK grouped-conv solvers, and the handle_test suite would fail or produce a false negative on gfx1250 hardware.

Technical Details

Two additive, one-line changes following the same pattern used for prior gfx generations:

  1. projects/miopen/src/ck_impl/CMakeLists.txt — Added gfx1250 to _CK_SUPPORTED_ARCHS. This list gates which GPU targets receive CK grouped-conv kernel compilation within MIOpen's CMake build. Missing entries cause the target to be silently filtered out of the grouped-conv solver set.

  2. projects/miopen/test/gtest/handle_test.cpp — Added "gfx1250" to the static expected-architecture array in test_arch_name(). This test validates that MIOpen::Handle::GetDeviceName() returns a string from the known-good set; omitting gfx1250 would cause a test failure on gfx1250 hardware.

No logic changes, no API surface modifications, and no existing architectures are affected.

Risk Assessment

Risk Level: 🟢 Low

Level Indicators
🟢 Low Purely additive: one new entry in a CMake arch list, one new string in a gtest array. No logic changes, no existing architecture affected, trivially revertable.

Impacted Components

  • projects/miopen/src/ck_impl/CMakeLists.txt — CK grouped-conv solver build configuration
  • projects/miopen/test/gtest/handle_test.cpp — Handle/arch-name unit test

Potential Side Effects

  • Builds targeting gfx1250 will now attempt to compile CK grouped-conv kernels. If CK itself does not yet fully support gfx1250, those builds may surface new compilation errors — this is the expected discovery mechanism and not a regression for any existing target.
  • No side effects on any other GPU architecture.

Mitigation Steps

  • The change is purely additive and trivially revertable with a single-line removal in each file.
  • CI will exercise the updated handle_test and any gfx1250-targeted build jobs, catching regressions immediately.

Test Plan

  • Run the failing smoke tests and confirm that they are not failing with the following errors anymore:

  • Missing arch in gtest

Value of: std::any_of(known_arch.begin(), known_arch.end(),
           [&](std::string arch) { return arch == this_arch; })
  Actual: false
  Expected: true
  • Add CK to gfx1250 whitelist
MIOpen(HIP): Warning [OpenRuntimeLibraryForDevice] CK grouped conv library not found for device gfx1250: libMIOpenCKGroupedConv_gfx1250.so: cannot open shared object file: No such file or directory

Test Result

  • unknown_gpu exception
CPU_Handle_NONE
GPU_MIOpenDriverGemmTest_FP16 
GPU_UnitTestConvSolverFFTFwd_FP32 / FFTBwd_FP32 
GPU_UnitTestActivationDescriptor_FP32 / FP16 
GPU_UnitTestConvSolverWinoRage2x3{Fwd,Bwd,Wrw}_FP16
GPU_UnitTestConvSolverWinoFury2x3{Fwd,Bwd,Wrw}_FP16 
GPU_UnitTestConvSolverTransposedBinWinograd*
GPU_UnitTestConvSolverImplicitGemmGroup{Fwd,Wrw}Xdlops_{FP16,BFP16,FP32,TF32} 
GPU_UnitTestConvSolverGemmFwd* / GemmWrw* 
GPU_CBAFind2FusionWorkspace_FP32 (2 tests — also shows "Gpu data is all zeros")
GPU_GemmFwdRest_LargeMemory_{FP32,FP16}, GPU_GemmBwdRest_LargeMemory_{FP32,FP16}, GPU_GemmWrwUniversal_LargeMemory_{FP32,FP16} 

Submission Checklist

@therock-pr-bot

therock-pr-bot Bot commented Jun 26, 2026

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
🌿 Branch Name ✅ Pass
📝 PR Title/Description ❌ Fail Error: Title does not follow Conventional Commits style.
Expected: start with a valid type (feat, fix, docs, …).
Desired format: type(optional-scope): short description
Forbidden Files ✅ Pass
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🔎 pre-commit ✅ Pass
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Title/Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

@therock-pr-bot

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Title/Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@SreecharanGundaboluAMD SreecharanGundaboluAMD changed the title [ALMIOPEN-2138] Add gfx1250 to MIOpen CK supported archs and known arch list [ROCM-27193] Add gfx1250 to MIOpen CK supported archs and known arch list Jun 26, 2026
@BradPepersAMD BradPepersAMD merged commit e7a5214 into develop Jul 2, 2026
54 of 55 checks passed
@BradPepersAMD BradPepersAMD deleted the users/SreecharanGundaboluAMD/fix_gfx1250_smake_tests branch July 2, 2026 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants