fix(ci): pass docs-preview shell inputs via env vars#8880
Merged
pmoutsias-amd merged 1 commit intoJul 3, 2026
Conversation
Route PR-derived values through step env blocks instead of inline expression interpolation, and restrict the preview to upstream branches.
1 task
github-actions
Bot
added
github actions
project: none
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
alexxu-amd
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Standardizes how
.github/workflows/docs-pr-preview.ymlpasses PR-derived values to shell steps. Branch name, detected project, and derived slugs now flow through the stepenv:block and are referenced as shell variables, rather than being interpolated inline.Changes
SUBTREES,BRANCH_NAME,PROJECT_SLUG,VERSION_SLUG,DOC_BASE,FOLDER_NAME) through the stepenv:block and reference them as shell variables instead of inline${{ }}expressions.Behavior impact
/docs-previewcomment on an upstream-branch PR).Testing
This workflow is triggered by
issue_comment, which always runs the copy on the default branch, so it can't be exercised from within this PR. Validation is post-merge:/docs-previewon an upstream-branch PR and confirm the preview builds and the URL is posted as before.JIRA ID: ROCM-27098