fix(tensilelite): Auto-derive arch marks from Architecture field and filename#8935
Open
archana-ramalingam wants to merge 2 commits into
Open
fix(tensilelite): Auto-derive arch marks from Architecture field and filename#8935archana-ramalingam wants to merge 2 commits into
archana-ramalingam wants to merge 2 commits into
Conversation
github-actions
Bot
added
project: hipblaslt
project: hipsparselt
ci:hipsparselt-fast
labels
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
archana-ramalingam
changed the title
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
4 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (76.92%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #8935 +/- ##
========================================
Coverage 71.27% 71.27%
========================================
Files 2613 2613
Lines 409506 409506
Branches 61210 61210
========================================
Hits 291868 291868
Misses 96183 96183
Partials 21455 21455
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
…filename Add two new mark derivation layers to configMarks() so that `-m gfx1250` collects all gfx1250 tests without requiring manual TestParameters.marks entries or `-k` keyword filtering: - Layer 2: GlobalParameters.Architecture value → pytest mark - Layer 3: gfx\d+ regex match in YAML filename → pytest mark Together with the existing directory-name layer (Layer 1), all 99 gfx1250 tests get the gfx1250 mark with zero gaps. This eliminates 17 spurious skips and catches stinky_sia4.yaml which was previously missed by the `-k gfx1250` keyword filter. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
archana-ramalingam
force-pushed
the
users/aramalin/gfx1250-yaml-marks
branch
from
3212208 to
a314cf3
Compare
archana-ramalingam
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
gfx1250 test YAMLs under
gemm/gfx12/only get thegfx12pytest mark fromconfigMarks(), forcing TheRock to use-m "gfx1250 or gfx12"which pulls in 17 unrelated gfx12-only tests as spurious skips.Technical Details
Add two mark derivation layers to
configMarks()inconfig_helpers.py:Architecturefield:GlobalParameters.Architecture: gfx1250→ markgfx1250gfx\d+in YAML filename → mark (e.g.,bf16_gfx1250.yaml→gfx1250)Together with the existing directory-name layer, all 99 gfx1250 tests receive the
gfx1250mark with zero gaps.-m gfx1250eliminating spurious skips.Test Plan
-m gfx1250Test Result
Submission Checklist
JIRA ID: AIHPBLAS-3508