BlasLt interface refactoring and important MatmulPlan cache fixes#994
Open
pemeliya wants to merge 1 commit into
Open
BlasLt interface refactoring and important MatmulPlan cache fixes#994pemeliya wants to merge 1 commit into
pemeliya wants to merge 1 commit into
Conversation
- Refactor BlasLt::Get() to take StreamExecutor* and return StatusOr<BlasLt*> - Remove static convenience methods (GetMatmulPlan, GetGroupedMatmulPlan) - Remove Stream* parameter from GetAlgorithms - Split ROCm MatmulPlan into RegularMatmulPlan and GroupedMatmulPlan - Remove redundant ExecuteOnStream overloads from base class - Rename internal members (parent_ -> executor_, blas_lt_ -> handle_) - Update all callers (autotuners, SYCL backend) clang format clang tidy clang tidy clang tidy clang tidy fixes after rebase fixing deps clang format fix fixing cuda test fixing cuda inlined NYI GroupedMatmulPlan for SyCL addressing comments cherry-picking gpu_blas_lt refactoring changes from upstream
pemeliya
force-pushed
the
pemeliya/v0.9.1_gpu_blaslt_refactor
branch
from
832bf4a to
9a20615
Compare
i-chaochen
approved these changes
Jun 26, 2026
i-chaochen
left a comment
i-chaochen
left a comment
Collaborator
There was a problem hiding this comment.
it's ok to me, but please advice JAX team earlier next time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picking from openxla#42239 and openxla#43503