Translator feedback issue1350#2851
Merged
Merged
Conversation
dkoslicki
approved these changes
Jul 20, 2026
Collaborator
Author
|
Hi @edeutsch, could you please let me know whether we are ready to merge it into master and then deploy the fix? This fix doesn't change anything in the existing xDTD database but only updates the code to extract the related info. Thank you! |
edeutsch
approved these changes
Jul 20, 2026
Collaborator
|
Hi @chunyuma this looks fine to me to merge and deploy. |
Collaborator
Author
|
Thanks @edeutsch. I will merge it to the master branch. Could you please help me deploy it? Thank you! |
Collaborator
|
deployed to arax.ncats.io |
Collaborator
Author
|
Thank you so much @edeutsch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is created to fix the issue of missing the expected
source_record_urlsdata in the MVP1 query (reported by https://github.com/NCATSTranslator/Feedback/issues/1353). Basically, it did the following main updates:infer_utilities.py, add code to recover the expectedsource_record_urlsdata from the xdtd database.test_ARAX_infer.pyfor confirmingsource_record_urlsdata is indeed recovered.