Closed
Conversation
for the from-stow feature: 1. from-stow wants to convert into a temporary directory but it failed because it never created the temp dir ; now it does 2. refactor help text so that it shows up when you run tuckr -h from-stow (not just when you run the command itself) 3. if dotfiles_old already exists we exit with a clear message saying this (instead of an error when we try to rename the existing dotfiles dir) 4. misc, minor adjustments to dry-run - tidying up messages, and also prevent a failure when the new, temp dotfiles dir wasn't created
Author
|
Sorry - the additional info is printed when you use |
Owner
|
I found this implementation rather messy. I went to tweak the command to fix it myself and I couldn't do it. So my implementation itself is also bad. So I'm just gonna rewrite this command altogether. I'll keep the commit up for now so that I can look at your bullet points. |
Author
|
Would you happen to have a style guide that you could share? |
Owner
|
With a fresh mind I managed to adapt the old code and fix all the issues. I've added pretty much all your bullet points. Test it out and let me know if something comes up |
MikeTheGreat
added a commit
to MikeTheGreat/Tuckr
that referenced
this pull request
Nov 8, 2025
Author
|
Thanks! I've got a reply in #116 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for the from-stow feature: